* [PATCH 2/8] http: document event_write usage
2016-02-29 1:40 6% [PATCH 0/8] another round of HTTP-related fixes Eric Wong
@ 2016-02-29 1:41 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-02-29 1:41 UTC (permalink / raw)
To: meta
It may not be obvious where we are when we enter the event_write
callback. Hopefully this clarifies things.
---
lib/PublicInbox/HTTP.pm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index 4d771f2..a472388 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -201,10 +201,9 @@ sub event_write {
# only continue watching for readability when we are done writing:
return if $self->write(undef) != 1;
- if ($self->{rbuf} eq '') {
+ if ($self->{rbuf} eq '') { # wait for next request
$self->watch_read(1);
- } else {
- # avoid recursion for pipelined requests
+ } else { # avoid recursion for pipelined requests
Danga::Socket->AddTimer(0, sub { rbuf_process($self) });
}
}
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/8] another round of HTTP-related fixes
@ 2016-02-29 1:40 6% Eric Wong
2016-02-29 1:41 7% ` [PATCH 2/8] http: document event_write usage Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-02-29 1:40 UTC (permalink / raw)
To: meta
git clone for Smart HTTP now works properly when using Apache2 \o/
Eric Wong (8):
http: error check for sysseek on input
http: document event_write usage
http: avoid needless time2str calls
distinguish error messages intended for users vs developers
favor procedural calls for most private functions
git-http-backend: stricter parsing of CRLF
spawnpp: use env(1) for mod_perl compatibility
git-http-backend: fixes for mod_perl
lib/PublicInbox/Config.pm | 6 +++---
lib/PublicInbox/Daemon.pm | 18 ++++++++----------
lib/PublicInbox/GitHTTPBackend.pm | 12 ++++++------
lib/PublicInbox/HTTP.pm | 40 ++++++++++++++++++++++-----------------
lib/PublicInbox/NNTP.pm | 30 ++++++++++++++---------------
lib/PublicInbox/Spawn.pm | 3 ++-
lib/PublicInbox/SpawnPP.pm | 9 ++-------
lib/PublicInbox/WWW.pm | 2 +-
script/public-inbox-httpd | 2 +-
9 files changed, 61 insertions(+), 61 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-02-29 1:40 6% [PATCH 0/8] another round of HTTP-related fixes Eric Wong
2016-02-29 1:41 7% ` [PATCH 2/8] http: document event_write usage Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).