* [PATCH 6/8] git-http-backend: stricter parsing of CRLF
2016-02-29 1:40 5% [PATCH 0/8] another round of HTTP-related fixes Eric Wong
@ 2016-02-29 1:41 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-02-29 1:41 UTC (permalink / raw)
To: meta
It is not needed as we know git uses CRLF termination.
---
lib/PublicInbox/GitHTTPBackend.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 6e8ad95..8e6d8b6 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -201,11 +201,11 @@ sub serve_smart {
if ($fh) { # stream body from git-http-backend to HTTP client
$fh->write($buf);
$buf = '';
- } elsif ($buf =~ s/\A(.*?)\r?\n\r?\n//s) { # parse headers
+ } elsif ($buf =~ s/\A(.*?)\r\n\r\n//s) { # parse headers
my $h = $1;
my $code = 200;
my @h;
- foreach my $l (split(/\r?\n/, $h)) {
+ foreach my $l (split(/\r\n/, $h)) {
my ($k, $v) = split(/:\s*/, $l, 2);
if ($k =~ /\AStatus\z/i) {
$code = int($v);
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/8] another round of HTTP-related fixes
@ 2016-02-29 1:40 5% Eric Wong
2016-02-29 1:41 7% ` [PATCH 6/8] git-http-backend: stricter parsing of CRLF Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-02-29 1:40 UTC (permalink / raw)
To: meta
git clone for Smart HTTP now works properly when using Apache2 \o/
Eric Wong (8):
http: error check for sysseek on input
http: document event_write usage
http: avoid needless time2str calls
distinguish error messages intended for users vs developers
favor procedural calls for most private functions
git-http-backend: stricter parsing of CRLF
spawnpp: use env(1) for mod_perl compatibility
git-http-backend: fixes for mod_perl
lib/PublicInbox/Config.pm | 6 +++---
lib/PublicInbox/Daemon.pm | 18 ++++++++----------
lib/PublicInbox/GitHTTPBackend.pm | 12 ++++++------
lib/PublicInbox/HTTP.pm | 40 ++++++++++++++++++++++-----------------
lib/PublicInbox/NNTP.pm | 30 ++++++++++++++---------------
lib/PublicInbox/Spawn.pm | 3 ++-
lib/PublicInbox/SpawnPP.pm | 9 ++-------
lib/PublicInbox/WWW.pm | 2 +-
script/public-inbox-httpd | 2 +-
9 files changed, 61 insertions(+), 61 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-02-29 1:40 5% [PATCH 0/8] another round of HTTP-related fixes Eric Wong
2016-02-29 1:41 7% ` [PATCH 6/8] git-http-backend: stricter parsing of CRLF Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).