* [PATCH 1/6] git: workaround occasional -watch error message
2024-01-09 11:39 4% [PATCH 0/6] WWW updates Eric Wong
@ 2024-01-09 11:39 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2024-01-09 11:39 UTC (permalink / raw)
To: meta
I'm not sure how this happens (perl 5.34.1 on FreeBSD 13.2)
but it appears the {sock} check can succeed and then go undef
and become unable to call ->owner_pid.
This happens when libgit2 is in use, so perhaps that's a factor.
In any case, the rest of the tests succeed.
---
lib/PublicInbox/Git.pm | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 6c4fcf93..7b991c6b 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -208,8 +208,17 @@ sub cat_async_retry ($$) {
sub gcf_inflight ($) {
my ($self) = @_;
+ # FIXME: the first {sock} check can succeed but Perl can complain
+ # about calling ->owner_pid on an undefined value. Not sure why or
+ # how this happens but t/imapd.t can complain about it, sometimes.
if ($self->{sock}) {
- return $self->{inflight} if $self->{sock}->owner_pid == $$;
+ if (eval { $self->{sock}->owner_pid == $$ }) {
+ return $self->{inflight};
+ } elsif ($@) {
+ no warnings 'uninitialized';
+ warn "E: $self sock=$self->{sock}: owner_pid failed: ".
+ "$@ (continuing...)";
+ }
delete @$self{qw(sock inflight)};
} else {
$self->close;
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] WWW updates
@ 2024-01-09 11:39 4% Eric Wong
2024-01-09 11:39 7% ` [PATCH 1/6] git: workaround occasional -watch error message Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2024-01-09 11:39 UTC (permalink / raw)
To: meta
1/6 is something I hit on FreeBSD *shrug*
3/6 came out of an abandoned (for now) idea for the cache in 5/6
4/6 is preparation for 5/6
5/6 linkification is something I've wanted for a while, but held
off since it could get expensive and WWW is already slow enough.
More WWW stuff on the way to wire up coderepos for the release
(6/6 is the start of that) but ugh, my mind wanders towards
weird optimization ideas instead :x
Eric Wong (6):
git: workaround occasional -watch error message
doc: txt2pre: linkify -extindex(1), dedupe -config(5)
test_common: key2sub: don't require final ';' in scripts
git: lowercase host in host_prefix_url
www: linkify inbox addresses in To/Cc headers
www: use autodie in more coderepo places
Documentation/txt2pre | 2 +-
lib/PublicInbox/Git.pm | 13 ++++++-
lib/PublicInbox/SearchView.pm | 2 +-
lib/PublicInbox/TestCommon.pm | 2 +-
lib/PublicInbox/View.pm | 70 ++++++++++++++++++++++++++++++----
lib/PublicInbox/ViewVCS.pm | 11 ++----
lib/PublicInbox/WwwCoderepo.pm | 5 ++-
7 files changed, 84 insertions(+), 21 deletions(-)
^ permalink raw reply [relevance 4%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2024-01-09 11:39 4% [PATCH 0/6] WWW updates Eric Wong
2024-01-09 11:39 7% ` [PATCH 1/6] git: workaround occasional -watch error message Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).