* [PATCH] extmsg: support "//" protocol-relative URLs
@ 2016-02-22 1:49 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2016-02-22 1:49 UTC (permalink / raw)
To: meta
Avoid unintentionally switching protocols if the external site
we're linking to supports both HTTP and HTTPS.
We do not want to force HTTPS everywhere because potential
bugs and performance problems in the TLS stack may outweigh
the privacy benefits. Leave up to site authors and users
to decide whether they want HTTPS or plain old HTTP.
---
lib/PublicInbox/ExtMsg.pm | 22 ++++++++++++++++------
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm
index 98da45c..d89a7e3 100644
--- a/lib/PublicInbox/ExtMsg.pm
+++ b/lib/PublicInbox/ExtMsg.pm
@@ -16,8 +16,9 @@ use PublicInbox::MID qw/mid2path/;
our @EXT_URL = (
'http://mid.gmane.org/%s',
'https://lists.debian.org/msgid-search/%s',
- 'http://mid.mail-archive.com/%s',
- 'http://marc.info/?i=%s',
+ # leading "//" denotes protocol-relative (http:// or https://)
+ '//mid.mail-archive.com/%s',
+ '//marc.info/?i=%s',
);
sub ext_msg {
@@ -84,13 +85,21 @@ sub ext_msg {
eval { require PublicInbox::Msgmap };
my $have_mm = $@ ? 0 : 1;
+ my $cgi = $ctx->{cgi};
+ my $base_url;
+ my $scheme;
+ if (ref($cgi) eq 'CGI') {
+ $base_url = $cgi->url(-base) . '/';
+ $scheme = $cgi->protocol;
+ } else { # Plack::Request
+ $base_url = $cgi->base->as_string;
+ $scheme = $cgi->env->{'psgi.url_scheme'};
+ }
if ($have_mm) {
my $tmp_mid = $mid;
+ my $url;
again:
- my $cgi = $ctx->{cgi};
- my $url = ref($cgi) eq 'CGI' ? $cgi->url(-base) . '/'
- : $cgi->base->as_string; # Plack::Request
- $url .= $listname;
+ $url = $base_url . $listname;
unshift @pfx, { git_dir => $ctx->{git_dir}, url => $url };
foreach my $pfx (@pfx) {
my $git_dir = delete $pfx->{git_dir} or next;
@@ -137,6 +146,7 @@ again:
$code = 300;
$s .= "\nPerhaps try an external site:\n\n";
foreach my $u (@EXT_URL) {
+ $u = "$scheme:$u" if $u =~ m!\A//!;
my $r = sprintf($u, $href);
my $t = sprintf($u, $html);
$s .= qq{<a\nhref="$r">$t</a>\n};
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-02-22 1:49 7% [PATCH] extmsg: support "//" protocol-relative URLs Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).