* [PATCH 0/5] cgit + WwwHighlight.pm integration
@ 2019-04-24 23:02 7% Eric Wong
2019-04-24 23:02 6% ` [PATCH 5/5] examples/cgit-commit-filter.lua: some doc updates Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-04-24 23:02 UTC (permalink / raw)
To: meta
cgit-wwwhighlight-filter.lua can benefit cgit installations by
allowing them to avoid spawning a new process for about-filter
and source-filter in cgitrc.
Instead of spawning highlight(1) or similar every time a cgit
filter is invoked, we can have a long-lived PSGI server running
WwwHighlight.pm(*) and rely on lua-http to access the server
over loopback.
WwwHighlight.pm is also updated to support the same
linkification logic we use for emails.
(*) see examples/highlight.psgi
Eric Wong (5):
wwwhighlight: do linkification, too
examples/cgit-commit-filter: remove unused variable
wwwhighlight: deal with no-op highlight
examples: cgit filter for use with WwwHighlight
examples/cgit-commit-filter.lua: some doc updates
MANIFEST | 1 +
examples/cgit-commit-filter.lua | 10 ++++-
examples/cgit-wwwhighlight-filter.lua | 57 +++++++++++++++++++++++++++
lib/PublicInbox/WwwHighlight.pm | 11 +++++-
4 files changed, 77 insertions(+), 2 deletions(-)
create mode 100644 examples/cgit-wwwhighlight-filter.lua
^ permalink raw reply [relevance 7%]
* [PATCH 5/5] examples/cgit-commit-filter.lua: some doc updates
2019-04-24 23:02 7% [PATCH 0/5] cgit + WwwHighlight.pm integration Eric Wong
@ 2019-04-24 23:02 6% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-04-24 23:02 UTC (permalink / raw)
To: meta
It's been a while since I wrote this, and it needs to be kept
up-to-date with some advances in our Perl code.
---
examples/cgit-commit-filter.lua | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/examples/cgit-commit-filter.lua b/examples/cgit-commit-filter.lua
index a8f9e1d..1677253 100644
--- a/examples/cgit-commit-filter.lua
+++ b/examples/cgit-commit-filter.lua
@@ -13,6 +13,9 @@
local urls = {}
urls['public-inbox.git'] = 'https://public-inbox.org/meta/'
-- additional URLs here...
+-- TODO we should be able to auto-generate this based on "coderepo"
+-- directives in the public-inbox config file; but keep in mind
+-- the mapping is M:N between inboxes and coderepos
function filter_open(...)
lineno = 0
@@ -20,6 +23,9 @@ function filter_open(...)
end
function filter_close()
+ -- cgit opens and closes this filter for the commit subject
+ -- and body separately, and we only generate the link based
+ -- on the commit subject:
if lineno == 1 and string.find(buffer, "\n") == nil then
u = urls[os.getenv('CGIT_REPO_URL')]
if u == nil then
@@ -32,6 +38,9 @@ function filter_close()
html('</tt></a>')
end
else
+ -- pass the body-through as-is
+ -- TODO: optionally use WwwHighlight for linkification like
+ -- cgit-wwwhighlight-filter.lua
html(buffer)
end
return 0
--
EW
^ permalink raw reply related [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-04-24 23:02 7% [PATCH 0/5] cgit + WwwHighlight.pm integration Eric Wong
2019-04-24 23:02 6% ` [PATCH 5/5] examples/cgit-commit-filter.lua: some doc updates Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).