* [PATCH 2/4] evcleanup: micro-optimize asap function
2016-06-25 0:45 6% [PATCH 0/4] http + mbox: tiny optimizations Eric Wong
@ 2016-06-25 0:45 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-06-25 0:45 UTC (permalink / raw)
To: meta
Instead of relying on a timer with immediate callback,
arm a pipe to watch for writability, ensuring the callback
always fires.
---
lib/PublicInbox/EvCleanup.pm | 42 +++++++++++++++++++++++++++++++++---------
1 file changed, 33 insertions(+), 9 deletions(-)
diff --git a/lib/PublicInbox/EvCleanup.pm b/lib/PublicInbox/EvCleanup.pm
index 5efb093..61837b8 100644
--- a/lib/PublicInbox/EvCleanup.pm
+++ b/lib/PublicInbox/EvCleanup.pm
@@ -5,32 +5,56 @@
package PublicInbox::EvCleanup;
use strict;
use warnings;
+use base qw(Danga::Socket);
+use fields qw(rd);
+my $singleton;
+my $asapq = [ [], undef ];
+my $laterq = [ [], undef ];
-my $asapq = { queue => [], timer => undef };
-my $laterq = { queue => [], timer => undef };
+sub once_init () {
+ my $self = fields::new('PublicInbox::EvCleanup');
+ my ($r, $w);
+ pipe($r, $w) or die "pipe: $!";
+ $self->SUPER::new($w);
+ $self->{rd} = $r; # never read, since we never write..
+ $self;
+}
sub _run_all ($) {
my ($q) = @_;
- my $run = $q->{queue};
- $q->{queue} = [];
- $q->{timer} = undef;
+ my $run = $q->[0];
+ $q->[0] = [];
+ $q->[1] = undef;
$_->() foreach @$run;
}
sub _run_asap () { _run_all($asapq) }
sub _run_later () { _run_all($laterq) }
+# Called by Danga::Socket
+sub event_write {
+ my ($self) = @_;
+ $self->watch_write(0);
+ _run_asap();
+}
+
+sub _asap_timer () {
+ $singleton ||= once_init();
+ $singleton->watch_write(1);
+ 1;
+}
+
sub asap ($) {
my ($cb) = @_;
- push @{$asapq->{queue}}, $cb;
- $asapq->{timer} ||= Danga::Socket->AddTimer(0, *_run_asap);
+ push @{$asapq->[0]}, $cb;
+ $asapq->[1] ||= _asap_timer();
}
sub later ($) {
my ($cb) = @_;
- push @{$laterq->{queue}}, $cb;
- $laterq->{timer} ||= Danga::Socket->AddTimer(60, *_run_later);
+ push @{$laterq->[0]}, $cb;
+ $laterq->[1] ||= Danga::Socket->AddTimer(60, *_run_later);
}
END {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] http + mbox: tiny optimizations
@ 2016-06-25 0:45 6% Eric Wong
2016-06-25 0:45 7% ` [PATCH 2/4] evcleanup: micro-optimize asap function Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-06-25 0:45 UTC (permalink / raw)
To: meta
For the gigantic $INBOX/all.mbox.gz response, this seems to slightly
improve speeds from roughly 290K/s to roughly 330K/s when fetching
out of a ~750MB aggressively-packed inbox.
Eric Wong (4):
http: always yield on getline/body
evcleanup: micro-optimize asap function
mbox: reduce small packets for gzipped mboxes
http: cork chunked responses for small savings
lib/PublicInbox/EvCleanup.pm | 42 +++++++++++++++++++++++++++++++++---------
lib/PublicInbox/HTTP.pm | 14 ++++++--------
lib/PublicInbox/Mbox.pm | 23 ++++++++++-------------
3 files changed, 49 insertions(+), 30 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-06-25 0:45 6% [PATCH 0/4] http + mbox: tiny optimizations Eric Wong
2016-06-25 0:45 7% ` [PATCH 2/4] evcleanup: micro-optimize asap function Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).