* [PATCH 08/12] eofpipe: drop {arg} support for now
2023-01-17 7:18 6% [PATCH 00/12] improve process reaping Eric Wong
@ 2023-01-17 7:19 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-01-17 7:19 UTC (permalink / raw)
To: meta
The only user of EOFpipe has no args, so avoid wasting a hash
slot on it. If we need it again in the future, EOFpipe will
allow an array of args, instead.
---
lib/PublicInbox/Daemon.pm | 2 +-
lib/PublicInbox/EOFpipe.pm | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/Daemon.pm b/lib/PublicInbox/Daemon.pm
index ee746f05..17e799ca 100644
--- a/lib/PublicInbox/Daemon.pm
+++ b/lib/PublicInbox/Daemon.pm
@@ -693,7 +693,7 @@ sub daemon_loop ($) {
if ($worker_processes > 0) {
$refresh->(); # preload by default
my $fh = master_loop(); # returns if in child process
- PublicInbox::EOFpipe->new($fh, \&worker_quit, undef);
+ PublicInbox::EOFpipe->new($fh, \&worker_quit);
} else {
reopen_logs();
$set_user->() if $set_user;
diff --git a/lib/PublicInbox/EOFpipe.pm b/lib/PublicInbox/EOFpipe.pm
index e537e2aa..628e9366 100644
--- a/lib/PublicInbox/EOFpipe.pm
+++ b/lib/PublicInbox/EOFpipe.pm
@@ -1,14 +1,14 @@
-# Copyright (C) 2020-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
package PublicInbox::EOFpipe;
-use strict;
+use v5.12;
use parent qw(PublicInbox::DS);
use PublicInbox::Syscall qw(EPOLLIN EPOLLONESHOT);
sub new {
- my (undef, $rd, $cb, $arg) = @_;
- my $self = bless { cb => $cb, arg => $arg }, __PACKAGE__;
+ my (undef, $rd, $cb) = @_;
+ my $self = bless { cb => $cb }, __PACKAGE__;
# 1031: F_SETPIPE_SZ, 4096: page size
fcntl($rd, 1031, 4096) if $^O eq 'linux';
$self->SUPER::new($rd, EPOLLIN|EPOLLONESHOT);
@@ -17,7 +17,7 @@ sub new {
sub event_step {
my ($self) = @_;
if ($self->do_read(my $buf, 1) == 0) { # auto-closed
- $self->{cb}->($self->{arg});
+ $self->{cb}->();
}
}
^ permalink raw reply related [relevance 7%]
* [PATCH 00/12] improve process reaping
@ 2023-01-17 7:18 6% Eric Wong
2023-01-17 7:19 7% ` [PATCH 08/12] eofpipe: drop {arg} support for now Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-01-17 7:18 UTC (permalink / raw)
To: meta
dwaitpid was implemented under the assumption our code could
eventually use a multithreaded Perl 5. Since the threads(3perl)
manpage officially discourages threads, that assumption proved
false. This series saves syscalls and improves ergonomics of
our internal APIs, data structures and code a small bit.
Eric Wong (12):
ipc: remove {-reap_async} field
t/solver_git.t: fix test message
qspawn: drop {psgi_env} deref
ds: introduce awaitpid, switch ProcessPipe users
git|gcf2: switch to awaitpid
watch: switch to awaitpid
watch: simplify internal data structures
eofpipe: drop {arg} support for now
watch: IMAP and NNTP polling can use the same interval
ipc: drop unused $args from ->ipc_worker_stop
ipc+lei: switch to awaitpid
ds: drop dwaitpid, switch to waitpid(-1)
Documentation/technical/ds.txt | 2 +-
lib/PublicInbox/DS.pm | 69 ++++++++++++------------
lib/PublicInbox/Daemon.pm | 2 +-
lib/PublicInbox/EOFpipe.pm | 10 ++--
lib/PublicInbox/Gcf2Client.pm | 5 +-
lib/PublicInbox/Git.pm | 10 ++--
lib/PublicInbox/IPC.pm | 39 +++++++-------
lib/PublicInbox/LEI.pm | 8 ++-
lib/PublicInbox/LeiConvert.pm | 2 +-
lib/PublicInbox/LeiInput.pm | 2 +-
lib/PublicInbox/LeiMirror.pm | 7 ++-
lib/PublicInbox/LeiStore.pm | 7 ++-
lib/PublicInbox/LeiToMail.pm | 11 ++--
lib/PublicInbox/LeiUp.pm | 5 +-
lib/PublicInbox/LeiXSearch.pm | 9 ++--
lib/PublicInbox/ProcessPipe.pm | 42 +++++++--------
lib/PublicInbox/Qspawn.pm | 61 ++++++++++-----------
lib/PublicInbox/Spawn.pm | 6 +--
lib/PublicInbox/Watch.pm | 96 ++++++++++++----------------------
script/public-inbox-clone | 2 +-
t/solver_git.t | 2 +-
t/spawn.t | 12 +++--
22 files changed, 186 insertions(+), 223 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-01-17 7:18 6% [PATCH 00/12] improve process reaping Eric Wong
2023-01-17 7:19 7% ` [PATCH 08/12] eofpipe: drop {arg} support for now Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).