* [PATCH 3/3] emlcontentfoo: quiet warning on missing attributes
@ 2020-05-09 8:27 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-05-09 8:27 UTC (permalink / raw)
To: meta
This bug was also present in Email::MIME::ContentType:
commit ae081fb576d8507efca4928116ad81efa756c723 (refs/pull/pull/9/head)
in https://github.com/rjbs/Email-MIME-ContentType.git
Our fix is shorter, but dependent on 5.10+ as our codebase
relies on Perl 5.10 features, anyways.
---
lib/PublicInbox/EmlContentFoo.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/EmlContentFoo.pm b/lib/PublicInbox/EmlContentFoo.pm
index 7472f8d2..e6005d29 100644
--- a/lib/PublicInbox/EmlContentFoo.pm
+++ b/lib/PublicInbox/EmlContentFoo.pm
@@ -190,7 +190,7 @@ sub _process_rfc2231 {
foreach (keys %{$attribs}) {
next unless $_ =~ m/^(.*)\*$/;
my $key = $1;
- next unless $attribs->{$_} =~ m/^$re_exvalue$/;
+ next unless ($attribs->{$_} // '') =~ m/^$re_exvalue$/;
my ($charset, $value) = ($1, $2);
$value =~ s/%([0-9A-Fa-f]{2})/pack('C', hex($1))/eg;
if (length $charset) {
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-05-09 8:27 [PATCH 0/3] eml: some fixes and speedups Eric Wong
2020-05-09 8:27 7% ` [PATCH 3/3] emlcontentfoo: quiet warning on missing attributes Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).