user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 0/6] ds: less is more
@ 2019-06-03  1:52  7% Eric Wong
  2019-06-03  1:52  6% ` [PATCH 1/6] ds: drop more unused subs Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-06-03  1:52 UTC (permalink / raw)
  To: meta

What's better than Free Software? Freedom FROM software!

Eric Wong (6):
  ds: drop more unused subs
  ds: add a note about planned future changes
  ds: drop set_writer_func support
  ds: drop checks for invalid descriptors
  ds: drop unused EVENT: label in epoll code path
  ds: drop write_set_watch field

 lib/PublicInbox/DS.pm        | 83 +++++-------------------------------
 lib/PublicInbox/EvCleanup.pm |  2 +-
 2 files changed, 12 insertions(+), 73 deletions(-)

-- 
EW

^ permalink raw reply	[relevance 7%]

* [PATCH 1/6] ds: drop more unused subs
  2019-06-03  1:52  7% [PATCH 0/6] ds: less is more Eric Wong
@ 2019-06-03  1:52  6% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-06-03  1:52 UTC (permalink / raw)
  To: meta

ToClose and HaveEpoll are of no use to us and I see no
future use for them, either.
---
 lib/PublicInbox/DS.pm        | 18 ------------------
 lib/PublicInbox/EvCleanup.pm |  2 +-
 2 files changed, 1 insertion(+), 19 deletions(-)

diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm
index 9142f21..89042cf 100644
--- a/lib/PublicInbox/DS.pm
+++ b/lib/PublicInbox/DS.pm
@@ -95,24 +95,6 @@ sub Reset {
     *EventLoop = *FirstTimeEventLoop;
 }
 
-=head2 C<< CLASS->HaveEpoll() >>
-
-Returns a true value if this class will use IO::Epoll for async IO.
-
-=cut
-sub HaveEpoll {
-    _InitPoller();
-    return $HaveEpoll;
-}
-
-=head2 C<< CLASS->ToClose() >>
-
-Return the list of sockets that are awaiting close() at the end of the
-current event loop.
-
-=cut
-sub ToClose { return @ToClose; }
-
 =head2 C<< CLASS->SetLoopTimeout( $timeout ) >>
 
 Set the loop timeout for the event loop to some value in milliseconds.
diff --git a/lib/PublicInbox/EvCleanup.pm b/lib/PublicInbox/EvCleanup.pm
index b2f8c08..afed24f 100644
--- a/lib/PublicInbox/EvCleanup.pm
+++ b/lib/PublicInbox/EvCleanup.pm
@@ -38,7 +38,7 @@ sub _run_all ($) {
 	$_->() foreach @$run;
 }
 
-# ensure PublicInbox::DS::ToClose fires after timers fire
+# ensure PublicInbox::DS::ToClose processing after timers fire
 sub _asap_close () { $asapq->[1] ||= _asap_timer() }
 
 sub _run_asap () { _run_all($asapq) }
-- 
EW


^ permalink raw reply related	[relevance 6%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-06-03  1:52  7% [PATCH 0/6] ds: less is more Eric Wong
2019-06-03  1:52  6% ` [PATCH 1/6] ds: drop more unused subs Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).