* Re: [PATCH] cindex: fix test when missing time(1) executable
2023-11-15 5:55 14% ` [PATCH] cindex: fix test when missing time(1) executable Eric Wong
@ 2023-11-15 13:25 8% ` Konstantin Ryabitsev
0 siblings, 0 replies; 2+ results
From: Konstantin Ryabitsev @ 2023-11-15 13:25 UTC (permalink / raw)
To: Eric Wong; +Cc: meta
On Wed, Nov 15, 2023 at 05:55:49AM +0000, Eric Wong wrote:
> Eric Wong <e@80x24.org> wrote:
> > +++ b/t/cindex.t
> > @@ -210,7 +210,7 @@ EOM
> > my $cmd = [ qw(-cindex -u --all --associate -d), "$tmp/ext",
> > '-I', $basic->{inboxdir} ];
> > $cidx_out = $cidx_err = '';
> > - ok(run_script($cmd, $env, $opt), 'associate w/o search');
> > + ok(run_script($cmd, $env, undef), 'associate w/o search');
> > like($cidx_err, qr/W: \Q$basic->{inboxdir}\E not indexed for search/,
> > 'non-Xapian-enabled inbox noted');
> > }
>
> Yeah, using this on your new VM showed the problem right away:
Yes, I can confirm that this hang is now gone. \o/
All the tests succeed now with the latest master.
Thanks, as always!
-K
^ permalink raw reply [relevance 8%]
* [PATCH] cindex: fix test when missing time(1) executable
@ 2023-11-15 5:55 14% ` Eric Wong
2023-11-15 13:25 8% ` Konstantin Ryabitsev
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-11-15 5:55 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: meta
Eric Wong <e@80x24.org> wrote:
> +++ b/t/cindex.t
> @@ -210,7 +210,7 @@ EOM
> my $cmd = [ qw(-cindex -u --all --associate -d), "$tmp/ext",
> '-I', $basic->{inboxdir} ];
> $cidx_out = $cidx_err = '';
> - ok(run_script($cmd, $env, $opt), 'associate w/o search');
> + ok(run_script($cmd, $env, undef), 'associate w/o search');
> like($cidx_err, qr/W: \Q$basic->{inboxdir}\E not indexed for search/,
> 'non-Xapian-enabled inbox noted');
> }
Yeah, using this on your new VM showed the problem right away:
------8<------
Subject: [PATCH] cindex: fix test when missing time(1) executable
It was only there for development purposes because associate is
slow, but it causes the test to get stuck on systems where it's
not available. So remove it and just call join(1posix).
Note: this is not the `time' builtin found in shells, this
executable shows memory and pagefault info (and more with the
`-v' switch). Unfortunately, it's not installed on many systems
despite being widely-packaged.
Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
---
lib/PublicInbox/CodeSearchIdx.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/CodeSearchIdx.pm b/lib/PublicInbox/CodeSearchIdx.pm
index 9ceef16c..3a30b5e5 100644
--- a/lib/PublicInbox/CodeSearchIdx.pm
+++ b/lib/PublicInbox/CodeSearchIdx.pm
@@ -890,7 +890,7 @@ sub associate {
my @pending = keys %{$self->{PENDING}};
die "E: pending=@pending jobs not done\n" if @pending;
progress($self, 'associating...');
- my @join = ('time', @JOIN, 'to_ibx_id', 'to_root_id');
+ my @join = (@JOIN, 'to_ibx_id', 'to_root_id');
my $rd = popen_rd(\@join, $CMD_ENV, { -C => "$TMPDIR" });
my %score;
while (<$rd>) { # PFX ibx_ids root_id
Much more gnarly work happening in this area :>
^ permalink raw reply related [relevance 14%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-11-14 21:50 t/cindex.t "associate w/o search" test hangs for me Konstantin Ryabitsev
2023-11-14 22:16 ` Eric Wong
2023-11-14 22:30 ` Konstantin Ryabitsev
2023-11-14 22:46 ` Eric Wong
2023-11-14 23:05 ` Konstantin Ryabitsev
2023-11-14 23:46 ` Eric Wong
2023-11-15 5:55 14% ` [PATCH] cindex: fix test when missing time(1) executable Eric Wong
2023-11-15 13:25 8% ` Konstantin Ryabitsev
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).