* [PATCH] build: check-manifest runs after tests
@ 2020-05-10 19:38 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-05-10 19:38 UTC (permalink / raw)
To: meta
And just treat it as a non-fatal nag when checking the rest of the
codebase. Calling it "check-manifest" as a `make' target
preserves the old behavior, which causes the check to fail
if a file were added to the worktree without changing the
MANIFEST.
---
Makefile.PL | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/Makefile.PL b/Makefile.PL
index 30b8adda2f0..472baa9b080 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -180,18 +180,22 @@ syntax:: \$(my_syntax)
changed = \$(shell git ls-files -m)
dsyn :: \$(addsuffix .syntax, \$(filter \$(changed), \$(syn_files)))
-check-manifest :: MANIFEST
- if test -e .git && git ls-files >\$?.gen 2>&1; then \\
- diff -u \$? \$?.gen; fi
+check_manifest := if test -e .git && git ls-files >MANIFEST.gen 2>&1; then \\
+ diff -u MANIFEST MANIFEST.gen; fi
+
+check-manifest : MANIFEST
+ \$(check_manifest)
# the traditional way running per-*.t processes:
-check-each :: pure_all check-manifest
+check-each :: pure_all
\$(EATMYDATA) \$(PROVE) --state=save -bvw -j\$(N)
+ -@\$(check_manifest)
# lightly-tested way to run tests, relies "--state=save" in check-each
# for best performance
-check-run :: pure_all check-manifest
+check-run :: pure_all
\$(EATMYDATA) \$(PROVE) -bvw t/run.perl :: -j\$(N)
+ -@\$(check_manifest)
check :: check-each
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-05-10 19:38 7% [PATCH] build: check-manifest runs after tests Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).