* [PATCH 3/2] address: explicitly reject local-only addresses
@ 2019-12-14 5:22 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2019-12-14 5:22 UTC (permalink / raw)
To: meta
Apparently, neither our previous address parsing code nor
Email::Address::XS recognizes local, username-only addresses
in the form of <username> (without "@host"). Without
this change, Email::Address::XS->address would return
"undef", so we need to filter it out via "grep { defined }"
It seems the cases where users email each other on the same
machine is small and public-inbox won't be able to index
addresses for those cases... Oh well :/
---
lib/PublicInbox/Address.pm | 9 ++++++---
t/address.t | 5 +++++
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/Address.pm b/lib/PublicInbox/Address.pm
index 433b36eb..c23a5d62 100644
--- a/lib/PublicInbox/Address.pm
+++ b/lib/PublicInbox/Address.pm
@@ -4,12 +4,15 @@ package PublicInbox::Address;
use strict;
use warnings;
-sub xs_emails { map { $_->address() } parse_email_addresses($_[0]) }
+sub xs_emails {
+ grep { defined } map { $_->address() } parse_email_addresses($_[0])
+}
sub xs_names {
- map {
+ grep { defined } map {
my $n = $_->name;
- $n = $_->user if $n eq $_->address;
+ my $addr = $_->address;
+ $n = $_->user if defined($addr) && $n eq $addr;
$n;
} parse_email_addresses($_[0]);
}
diff --git a/t/address.t b/t/address.t
index e7c0d6a8..1f20702a 100644
--- a/t/address.t
+++ b/t/address.t
@@ -38,6 +38,11 @@ sub test_pkg {
@names = $names->('"Quote Unneeded" <user@example.com>');
is_deeply(['Quote Unneeded'], \@names, 'extra quotes dropped');
+
+ my @emails = $emails->('Local User <user>');
+ is_deeply([], \@emails , 'no address for local address');
+ @names = $emails->('Local User <user>');
+ is_deeply([], \@names, 'no address, no name');
}
test_pkg('PublicInbox::Address');
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-12-14 1:02 [PATCH 0/2] use Email::Address::XS if available Eric Wong
2019-12-14 5:22 7% ` [PATCH 3/2] address: explicitly reject local-only addresses Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).