* Re: [PATCH 3/3] mboxgz: use Compress::Raw::Zlib instead of IO::Compress::Gzip
@ 2019-11-19 20:12 4% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2019-11-19 20:12 UTC (permalink / raw)
To: SZEDER Gábor; +Cc: meta
SZEDER Gábor <szeder.dev@gmail.com> wrote:
> I've just stumbled upon an issue that I suspect to be related to this
> patch series (or maybe just a strange coincidence...).
>
> When trying to download a mbox.gz with 'wget' I get a "501 Not
> Implemented", e.g.:
Thanks, fixed now. It's a bug in the build/install since
PublicInbox/MboxGz.pm was not installed (being a new file).
I made commit 4c20de0694d06ff3a5f963d7f51d509319060b50
("Makefile.PL: add dependency on MANIFEST contents") to
avoid that bug, but apparently it wasn't enough...
^ permalink raw reply [relevance 4%]
* [PATCH] Makefile.PL: MANIFEST dependency fix
@ 2019-11-27 12:17 5% Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2019-11-27 12:17 UTC (permalink / raw)
To: meta
We need to force an update to Makefile (not Makefile.PL) when
MANIFEST changes. Since "Makefile" (aka. "$(FIRST_MAKEFILE)")
is already a single-colon make target; we can't create a
double-colon rule to augment it. So we'll continue using a
"Makefile.PL" rule, but have it recreate the resulting Makefile
Finally, change the "check" target to use "prove -b" instead of
"prove -l" so we test against "blib/lib", since what's in the
"blib" dir will be installed.
Fixes: 4c20de0694d06ff3 ("Makefile.PL: add dependency on MANIFEST contents")
---
Makefile.PL | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Makefile.PL b/Makefile.PL
index f650fdea..4aa0caa7 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -86,13 +86,16 @@ check-manifest :: MANIFEST
if git ls-files >\$?.gen 2>&1; then diff -u \$? \$?.gen; fi
check:: pure_all check-manifest
- \$(EATMYDATA) prove -lvw -j\$(N)
+ \$(EATMYDATA) prove -bvw -j\$(N)
lib/PublicInbox/UserContent.pm :: contrib/css/216dark.css
\$(PERL) -I lib \$@ \$?
-# Ensure new .pm files will always be installed:
-Makefile.PL :: MANIFEST
+# Ensure new .pm files will always be installed by updating
+# the timestamp of Makefile.PL which forces Makefile to be remade
+Makefile.PL : MANIFEST
+ touch -r \$< \$@
+ \$(PERLRUN) \$@
EOF
}
^ permalink raw reply related [relevance 5%]
* [PATCH] Makefile.PL: add dependency on MANIFEST contents
@ 2019-10-06 23:01 7% Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2019-10-06 23:01 UTC (permalink / raw)
To: meta
This prevents breakage when running installed scripts when a
user fetches from git and forgets to run "perl Makefile.PL"
before "make install".
---
Makefile.PL | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Makefile.PL b/Makefile.PL
index 8daeb4fb..39b9b198 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -90,5 +90,8 @@ check:: pure_all check-manifest
lib/PublicInbox/UserContent.pm :: contrib/css/216dark.css
\$(PERL) -I lib \$@ \$?
+# Ensure new .pm files will always be installed:
+Makefile.PL :: MANIFEST
+
EOF
}
^ permalink raw reply related [relevance 7%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-10-06 23:01 7% [PATCH] Makefile.PL: add dependency on MANIFEST contents Eric Wong
2019-11-27 12:17 5% [PATCH] Makefile.PL: MANIFEST dependency fix Eric Wong
2019-11-16 2:34 [PATCH 0/3] start tidying up gzip-related code Eric Wong
2019-11-16 2:34 ` [PATCH 3/3] mboxgz: use Compress::Raw::Zlib instead of IO::Compress::Gzip Eric Wong
2019-11-19 13:57 ` SZEDER Gábor
2019-11-19 20:12 4% ` Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).