* [PATCH 1/3] view: reduce main landing page weight
2015-12-26 1:30 6% [PATCH 0/3] minor view tweaks Eric Wong
@ 2015-12-26 1:30 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2015-12-26 1:30 UTC (permalink / raw)
To: meta
Hopefully, "mbox.gz" is sufficiently understandabe that
we can get rid of the "title" attribute in <a> tags
(we already omitted the title in other pages).
Additionally, drop the '@' in front of the date.
The date should be obvious and is not necessary for
headers without author attribution.
---
lib/PublicInbox/View.pm | 23 +++++++++--------------
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 7603c51..ad90eb3 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -15,7 +15,6 @@ use PublicInbox::Hval;
use PublicInbox::MID qw/mid_clean id_compress mid2path/;
use Digest::SHA qw/sha1_hex/;
my $SALT = rand;
-my $MBOX_TITLE = 'title="download thread as gzipped mbox"';
require POSIX;
# TODO: make these constants tunable
@@ -205,7 +204,7 @@ sub emit_thread_html {
$next .= $final_anchor == 1 ? 'only message in' : 'end of';
$next .= " thread</a>, back to <a\nhref=\"../../\">index</a>";
$next .= "\ndownload thread: ";
- $next .= "<a\n$MBOX_TITLE\nhref=\"../t.mbox.gz\">mbox.gz</a>";
+ $next .= "<a\nhref=\"../t.mbox.gz\">mbox.gz</a>";
$next .= " / follow: <a\nhref=\"../t.atom\">Atom feed</a>";
$cb->write('<hr /><pre>' . $next . "\n\n".
$foot . '</pre></body></html>');
@@ -879,19 +878,15 @@ sub dump_topics {
my $attr;
$ts = fmt_ts($ts);
- if ($n == 1) {
- $attr = "@ $ts UTC";
- $n = "";
- } else {
- # $n isn't the total number of posts on the topic,
- # just the number of posts in the current results
- # window, so leave it unlabeled
- $attr = "@ $ts UTC";
- $n = " ($n)";
- }
+ $attr = " $ts UTC";
+
+ # $n isn't the total number of posts on the topic,
+ # just the number of posts in the current results
+ # window, so leave it unlabeled
+ $n = $n == 1 ? '' : " ($n+ messages)";
+
if ($level == 0 || $attr ne $prev_attr) {
- my $mbox = qq(<a\n$MBOX_TITLE\n) .
- qq(href="$mid/t.mbox.gz">mbox.gz</a>);
+ my $mbox = qq(<a\nhref="$mid/t.mbox.gz">mbox.gz</a>);
my $atom = qq(<a\nhref="$mid/t.atom">Atom</a>);
$pfx .= INDENT if $level > 0;
$dst .= $pfx . $attr . $n . " - $mbox / $atom\n";
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] minor view tweaks
@ 2015-12-26 1:30 6% Eric Wong
2015-12-26 1:30 7% ` [PATCH 1/3] view: reduce main landing page weight Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2015-12-26 1:30 UTC (permalink / raw)
To: meta
3 changes to be pushed to git://80x24.org/public-inbox.org master:
view: reduce main landing page weight
searchview: fix unclosed tags in threaded search results
use "Atom feed" consistently in headers/footers
lib/PublicInbox/Feed.pm | 2 +-
lib/PublicInbox/SearchView.pm | 15 ++++++---------
lib/PublicInbox/View.pm | 23 +++++++++--------------
3 files changed, 16 insertions(+), 24 deletions(-)
Additionally (sent separately):
searchview: fixup stupid syntax error
searchview: fix up Atom feed in search results
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-12-26 1:30 6% [PATCH 0/3] minor view tweaks Eric Wong
2015-12-26 1:30 7% ` [PATCH 1/3] view: reduce main landing page weight Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).