From: ebiederm@xmission.com (Eric W. Biederman)
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 2/4] PublicInbox::Config: Process mailboxes in sorted order
Date: Thu, 10 Oct 2019 06:05:10 -0500 [thread overview]
Message-ID: <87zhi83lp5.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <20191010094342.r57ubvl75trauj6b@dcvr> (Eric Wong's message of "Thu, 10 Oct 2019 09:43:42 +0000")
Eric Wong <e@80x24.org> writes:
> "Eric W. Biederman" <ebiederm@xmission.com> wrote:
>>
>> Date: Thu, 16 May 2019 19:26:47 -0500
>>
>> To make the results reproducible and comprehensible when
>> a large number of mail boxes are being processed process the
>> mail boxes in sorted order, instead of in random hash order.
>>
>> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
>> ---
>> lib/PublicInbox/Config.pm | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
>> index 9f3f8df7eeaa..9ec00b0ddb6d 100644
>> --- a/lib/PublicInbox/Config.pm
>> +++ b/lib/PublicInbox/Config.pm
>> @@ -128,7 +128,7 @@ sub each_inbox {
>> }
>> } else {
>> my %seen;
>> - foreach my $k (keys %$self) {
>> + foreach my $k (sort keys %$self) {
>> $k =~ m!\Apublicinbox\.([^/]+)\.mainrepo\z! or next;
>> next if $seen{$1};
>> $seen{$1} = 1;
>
> I'm not sure if that code path happens outside of tests.
> If it's parsing "git config -l" output, it'll use section_order
> which preserves the ordering of the config file.
>
> Will take a deeper look tomorrow (and possibly rewrite those
> tests to parse a scalarref instead of just taking a hashref).
I know I have at least one use in my import_imap_inbox script.
Looking at the dates it looks like I added this in July 2018, and you
added section order in January 2019. So it may be you have a better fix
in place already and I simply hadn't noticed.
Eric
next prev parent reply other threads:[~2019-10-10 11:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 22:13 Do I need multiple publicinbox.<name>.address values? Alyssa Ross
2019-10-08 0:10 ` Eric Wong
2019-10-08 12:18 ` Eric W. Biederman
2019-10-08 12:23 ` [PATCH] Config.pm: Add support for mailing list information Eric W. Biederman
2019-10-08 22:11 ` Do I need multiple publicinbox.<name>.address values? Eric Wong
2019-10-08 22:24 ` Eric W. Biederman
2019-10-08 22:41 ` Eric Wong
2019-10-09 7:58 ` Eric W. Biederman
2019-10-09 8:15 ` [PATCH 0/4] Various bits to support import_imap_mailbox Eric W. Biederman
2019-10-09 8:16 ` [PATCH 1/4] PublicInbox::Import Smuggle a raw message into add Eric W. Biederman
2019-10-15 20:26 ` Eric Wong
2019-10-15 23:05 ` Eric W. Biederman
2019-10-09 8:17 ` [PATCH 2/4] PublicInbox::Config: Process mailboxes in sorted order Eric W. Biederman
2019-10-10 9:43 ` Eric Wong
2019-10-10 11:05 ` Eric W. Biederman [this message]
2019-10-09 8:23 ` [PATCH 3/4] Config.pm: Add support for looking up repos by their directories Eric W. Biederman
2019-10-09 8:25 ` [PATCH 4/4] IMAPTracker: Add a helper to track our place in reading imap mailboxes Eric W. Biederman
2019-10-10 19:08 ` ibx->{listid} autoviv fixup [was: [PATCH 0/4] Various bits to support import_imap_mailbox] Eric Wong
2019-10-10 21:23 ` Eric W. Biederman
2019-10-10 8:31 ` Do I need multiple publicinbox.<name>.address values? Eric Wong
2019-10-10 10:56 ` Eric W. Biederman
2019-10-09 11:59 ` Alyssa Ross
2019-10-10 10:06 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhi83lp5.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).