From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS6315 166.70.0.0/16 X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6CA7A1F62D; Fri, 6 Jul 2018 03:47:15 +0000 (UTC) Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fbHiE-0001Ny-9j; Thu, 05 Jul 2018 21:47:14 -0600 Received: from [97.119.167.31] (helo=x220.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fbHiD-0003hL-HG; Thu, 05 Jul 2018 21:47:14 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Eric Wong Cc: meta@public-inbox.org References: <87a7r6z1cy.fsf@xmission.com> <20180705231346.GA6524@dcvr> <87601turnf.fsf@xmission.com> Date: Thu, 05 Jul 2018 22:47:01 -0500 In-Reply-To: <87601turnf.fsf@xmission.com> (Eric W. Biederman's message of "Thu, 05 Jul 2018 19:36:20 -0500") Message-ID: <87o9flt496.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1fbHiD-0003hL-HG;;;mid=<87o9flt496.fsf@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=97.119.167.31;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19YznmOpd9g2iaOqCeKEp8PH7CMCVy2LHg= X-SA-Exim-Connect-IP: 97.119.167.31 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: Warnings from git fsck after lkml import X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) List-Id: ebiederm@xmission.com (Eric W. Biederman) writes: > Eric Wong writes: > >> "Eric W. Biederman" wrote: >>> It looks like public-inbox has some challenges when importing some >>> questionable emails. The import of lkml has resulted in several commits >>> with bad dates that git fsck complains about. I have previously >>> reported this to Konstantin Ryabitsev who maintains kernel.org but since >>> I have not seen any discussion of this I thought I should report it >>> directly here as well. >> >> Thanks for bringing this up publically. >> >> Yes, I early during v2 development I noticed old mails had some >> -1400 timezone values (but the furthest is -1200). I opted to >> attempt to preserve the wonky timezones since fast-import >> happily accepts -1400 and I didn't anticipate problems... > > I think 0.git was generated after your earlier fix. > > Looking at the commits in question this is a different issue. > On some of the later ones I am really not certain what it is > but here is a representative sample you can look at. Except below is looking at the pretty output of git show. To actually see the problem git show --format=raw is needed. Which for commit 59173dc1fe67b113ace4ce83e7f522414b3e0404 shows me: author Dieter Ferdinand 1166001998 +1 Which makes it clear the ``timezone'' was passed straight through without modification. The date in the email was: "Date: Wed, 13 Dec 2006 10:26:38 +1" And the problem is the timezone is not a 4 byte number. I see the same pattern with the rest of the bad time zone warnings. So it should be straight forward if the timezone is not 4 digits to just not pass the time zone through. Eric