user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: meta@public-inbox.org
Subject: From-munge not being reversed on mbox import
Date: Sat, 04 Apr 2020 04:58:51 +0000	[thread overview]
Message-ID: <87lfnb3kz8.fsf@kyleam.com> (raw)

I'm feeding mbox files created with Konstantin Ryabitsev's
list-archive-maker.py script [^1] to import_vger_from_mbox.  Looking
through the result, I noticed some ">From" lines.  Here's an example:

  https://yhetil.org/orgmode/871rpt9zc4.fsf@kyleam.com/

If I'm following the code correctly, that leads to an import_mbox call,
which in turn calls mb_add:

   sub mb_add ($$$$) {
       my ($im, $variant, $filter, $msg) = @_;
       $$msg =~ s/(\r?\n)+\z/$1/s;
       my $mime = PublicInbox::MIME->new($msg);
       if ($variant eq 'mboxrd') {
               $$msg =~ s/^>(>*From )/$1/sm;
       } elsif ($variant eq 'mboxo') {
               $$msg =~ s/^>From /From /sm;
       }
   [...]

So, it appears the ">From" _should_ be getting reversed.  To eliminate
any stupid things I may have done when creating the archive, I looked
for a message on meta that has an in-body line starting with "From" and
found

  https://public-inbox.org/meta/20200121222924.ioz5ve2sg65zcuoy@chatter.i7.local/

So I downloaded the public-inbox generated mbox and fed it to
import_vger_from_mbox:

  curl -s https://public-inbox.org/meta/20200121222924.ioz5ve2sg65zcuoy@chatter.i7.local/t.mbox.gz \
   | zcat | scripts/import_vger_from_mbox testing emacs-orgmode@gnu.org ~/inboxes/testing

That too leaves a ">From" in the body:

  https://yhetil.org/testing/20200121222924.ioz5ve2sg65zcuoy@chatter.i7.local/

Any idea what's going wrong here?


[^1]: https://git.kernel.org/pub/scm/linux/kernel/git/mricon/korg-helpers.git/plain/list-archive-maker.py

             reply	other threads:[~2020-04-04  4:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-04  4:58 Kyle Meyer [this message]
2020-04-04  6:20 ` [PATCH] inboxwritable: fix From_ line unescaping Eric Wong
2020-04-04 16:31   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfnb3kz8.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).