user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 2/2] doc: lei: add manpages for remaining commands
Date: Sat, 16 Oct 2021 11:13:41 -0400	[thread overview]
Message-ID: <87lf2t0zq2.fsf@kyleam.com> (raw)
In-Reply-To: <20211016070753.M426387@dcvr>

Eric Wong writes:

>> @@ -47,6 +53,7 @@ Documentation/lei-q.pod
>>  Documentation/lei-rediff.pod
>>  Documentation/lei-refresh-mail-sync.pod
>>  Documentation/lei-rm.pod
>> +Documentation/lei-rm-watch.pod
>>  Documentation/lei-security.pod
>>  Documentation/lei-store-format.pod
>>  Documentation/lei-tag.pod
>
> Curious, was that from `git ls-files >MANIFEST' ?

No, it wasn't.  I hadn't realized that the content of MANIFEST
corresponded directly to git-ls-files output, but poking around I see
there is even a check-manifest make target [*].  Doh.

So, I manually added this one, like the others I added.  I think my past
changes to this file have ended up in the expected order because I tend
to run Emacs's sort-lines to check my manual placement, but I must not
have done it here because sort-lines agrees with ls-files.

[...]
> No big deal, I can just flip and push it; I just don't want a
> reproducibility issue popping up.

Thanks, sorry about the mix up.


[*] I did run `make check' before sending, and it looks like that also
    checks MANIFEST _after_ running the test suite.  That didn't help me
    catch the MANIFEST sorting issue in this case because the test suite
    is failing on my end.

    I believe these failures are recent and was planning on looking into
    them today, either sending a patch or just reporting, depending on
    whether I could figure out a fix.  Anyway, here they are:

      t/psgi_multipart_not.t .......
      ok 1 - use HTTP::Request::Common;
      ok 2 - use Plack::Test;
      ok 3 - use PublicInbox::WWW;
      not ok 4 - /v2test/?q=%22ain't what it used to be%22&x=t
      not ok 5 - /v2test/?q=%22ain't what it used to be%22&x=t warns
      Failed 2/5 subtests



  reply	other threads:[~2021-10-16 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-16  5:39 [PATCH 0/2] doc: lei manpages for remaining commands Kyle Meyer
2021-10-16  5:39 ` [PATCH 1/2] doc: lei: restore alphabetical order to some listings Kyle Meyer
2021-10-16  5:39 ` [PATCH 2/2] doc: lei: add manpages for remaining commands Kyle Meyer
2021-10-16  7:07   ` Eric Wong
2021-10-16 15:13     ` Kyle Meyer [this message]
2021-10-16 16:58       ` Kyle Meyer
2021-10-16 17:03       ` Eric Wong
2021-10-16 17:21         ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf2t0zq2.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).