user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] nntp: add Path: header for leafnode
@ 2019-06-13  6:54 Eric Wong
  2019-06-13 17:53 ` Dave Taht
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2019-06-13  6:54 UTC (permalink / raw)
  To: meta; +Cc: Dave Taht

Apparently leafnode just needs any junk in the Path: header.
Lets not waste bandwidth and just use a single byte to keep
leafnode happy.

Cc: Dave Taht <dave@taht.net>
---
 lib/PublicInbox/NNTP.pm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 85778c4..5615cd7 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -435,6 +435,10 @@ sub xref ($$$$) {
 sub set_nntp_headers ($$$$$) {
 	my ($self, $hdr, $ng, $n, $mid) = @_;
 
+	# why? leafnode requires a Path: header for some inexplicable
+	# reason.  We'll fake the shortest one possible.
+	$hdr->header_set('Path', 'y');
+
 	# clobber some
 	my $xref = xref($self, $ng, $n, $mid);
 	$hdr->header_set('Xref', $xref);
-- 
EW


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] nntp: add Path: header for leafnode
  2019-06-13  6:54 [PATCH] nntp: add Path: header for leafnode Eric Wong
@ 2019-06-13 17:53 ` Dave Taht
  0 siblings, 0 replies; 2+ messages in thread
From: Dave Taht @ 2019-06-13 17:53 UTC (permalink / raw)
  To: Eric Wong; +Cc: meta

Eric Wong <e@80x24.org> writes:

> Apparently leafnode just needs any junk in the Path: header.
> Lets not waste bandwidth and just use a single byte to keep
> leafnode happy.
>
> Cc: Dave Taht <dave@taht.net>

Thx! awesome!

> ---
>  lib/PublicInbox/NNTP.pm | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
> index 85778c4..5615cd7 100644
> --- a/lib/PublicInbox/NNTP.pm
> +++ b/lib/PublicInbox/NNTP.pm
> @@ -435,6 +435,10 @@ sub xref ($$$$) {
>  sub set_nntp_headers ($$$$$) {
>  	my ($self, $hdr, $ng, $n, $mid) = @_;
>  
> +	# why? leafnode requires a Path: header for some inexplicable
> +	# reason.  We'll fake the shortest one possible.
> +	$hdr->header_set('Path', 'y');
> +
>  	# clobber some
>  	my $xref = xref($self, $ng, $n, $mid);
>  	$hdr->header_set('Xref', $xref);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-13  6:54 [PATCH] nntp: add Path: header for leafnode Eric Wong
2019-06-13 17:53 ` Dave Taht

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git