From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS6315 166.70.0.0/16 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_LOW,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AC7171F85E; Fri, 13 Jul 2018 22:52:05 +0000 (UTC) Received: from in01.mta.xmission.com ([166.70.13.51]) by out03.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fe6uy-0004CM-AV; Fri, 13 Jul 2018 16:52:04 -0600 Received: from [97.119.167.31] (helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fe6ux-0001KT-HB; Fri, 13 Jul 2018 16:52:03 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Eric Wong Cc: meta@public-inbox.org References: <87k1q1bky6.fsf@xmission.com> <20180712014715.dn5aouayoa3uejp4@dcvr> <87k1q07dyc.fsf@xmission.com> <20180712230946.mqv3yjw4aabf7xrf@dcvr.yhbt.net> <878t6f1ch7.fsf@xmission.com> <20180713220259.GA27845@dcvr> Date: Fri, 13 Jul 2018 17:51:57 -0500 In-Reply-To: <20180713220259.GA27845@dcvr> (Eric Wong's message of "Fri, 13 Jul 2018 22:02:59 +0000") Message-ID: <87bmbaycj6.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1fe6ux-0001KT-HB;;;mid=<87bmbaycj6.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=97.119.167.31;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX197KE+okBgYjGD2hGSoJKsukE2puxMYgjE= X-SA-Exim-Connect-IP: 97.119.167.31 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: bug: v2 deletes on incremental fetch [was: Q: V2 format] X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) List-Id: Eric Wong writes: > "Eric W. Biederman" wrote: >> Eric Wong writes: >> > "Eric W. Biederman" wrote: >> >> Then I am going to report a probable bug. In V2 in public-inbox-index >> >> I can not find a path from finding a 'd' file and a call to unindex. V1 >> >> unindexes deleted files. Rebased heads for purges call unindex. I >> >> don't see that for ordinary d files though. >> > >> > It shouldn't need to call unindex because they never get indexed >> > on rebuilds. V2 indexing walks history backwards (normal "git log" >> > behavior) so it remembers 'd' paths in the "$D" hash; and skips blobs >> > as it encounters them. >> > >> > v1 needed to unindex because it used "git log --reverse" to walk >> > forward in history. >> >> This assumes that you see them in the same git pull. I would think >> ideally anything that is going to be deleted that quickly you can just >> skip archiving. >> >> What is the time window of you expecting 'd' messages to appear? > > Ah, this is definitely a bug when using incremental fetch + -index. > Right now, it only warns on unseen entries in $D but won't reach > beyond the current "git log" window. > > I'll take a lookg at it later today/this weekend unless you're > already working on it. I am not. Eric