From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS6315 166.70.0.0/16 X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0D3721F6AC; Thu, 5 Jul 2018 05:40:58 +0000 (UTC) Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fax0j-0002Iy-3d; Wed, 04 Jul 2018 23:40:57 -0600 Received: from [97.119.159.215] (helo=x220.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fax0i-0002ZA-FM; Wed, 04 Jul 2018 23:40:56 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Cc: Eric Wong Date: Thu, 05 Jul 2018 00:40:45 -0500 Message-ID: <87a7r6z1cy.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1fax0i-0002ZA-FM;;;mid=<87a7r6z1cy.fsf@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=97.119.159.215;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/kEE2pr8ICUW64yxRD9nc15xMh5qMCB84= X-SA-Exim-Connect-IP: 97.119.159.215 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Warnings from git fsck after lkml import X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) List-Id: It looks like public-inbox has some challenges when importing some questionable emails. The import of lkml has resulted in several commits with bad dates that git fsck complains about. I have previously reported this to Konstantin Ryabitsev who maintains kernel.org but since I have not seen any discussion of this I thought I should report it directly here as well. At a practical level these errors initially preventing me from cloning the repos as in .gitconfig I had: > [transfer] > fsckobjects = true > [fetch] > fsckobjects = true > [receive] > fsckobjects = true Beyond the cloning issue while I don't expect public-inbox to fix the emails themselves it should be able to detect and prevent creating buggy commits. Importing a large repo like linux-kernel seems like a good test case for finding these kinds of issues. git fsck on lkml/git/0.git reports: > Checking object directories: 100% (256/256), done. > warning in commit 59173dc1fe67b113ace4ce83e7f522414b3e0404: badTimezone: invalid author/committer line - bad time zone > warning in commit ff22aaff22eb4479e49e93f697e385f76db51c55: badTimezone: invalid author/committer line - bad time zone > warning in commit 609b744909693f5f00aff5ed9928beeeee9ded2e: badTimezone: invalid author/committer line - bad time zone > warning in commit 084572141db8e0d879428afb278bd338f2dbb053: badTimezone: invalid author/committer line - bad time zone > warning in commit 789d204de27cd12c6da693d903390a241a1a4bca: badTimezone: invalid author/committer line - bad time zone > warning in commit 0d9a65948b0c957007ca387cd56b690f9bab9c08: badTimezone: invalid author/committer line - bad time zone > warning in commit f7468c42b4196ee6323afb373ab9323971c38d69: badTimezone: invalid author/committer line - bad time zone > warning in commit 85e0cd6dd527cd55ad0440f14384529b83818228: badTimezone: invalid author/committer line - bad time zone > warning in commit f31e19a2e772c9ed00728ef142af9c550ea5de6a: badTimezone: invalid author/committer line - bad time zone > warning in commit 56eb7384443ef84e17e29504a304a071b189ae67: badTimezone: invalid author/committer line - bad time zone > warning in commit e4470030471e6810414b9de5e3b52e16f2245d12: badTimezone: invalid author/committer line - bad time zone > warning in commit f913b48caa097c3b2cb3f491707944f88d52d89f: badTimezone: invalid author/committer line - bad time zone > warning in commit 4390f26923d572c6dab6cce8282c7cad5520d785: badTimezone: invalid author/committer line - bad time zone > warning in commit 0f66db71a06bd7d651a0cd80877d8043b70fda20: badTimezone: invalid author/committer line - bad time zone > warning in commit d71472c40b36dcdf0396afc9778f6137eea45887: badTimezone: invalid author/committer line - bad time zone > warning in commit e8d3b19a91a2d86b6a91bd19dc811e851398b519: badTimezone: invalid author/committer line - bad time zone > warning in commit afd9fc0cc87e56ed7736d633e17d0ef77817b3cc: badTimezone: invalid author/committer line - bad time zone > warning in commit 811b3217708358cf1b75fba4602a64a426fce0f5: badTimezone: invalid author/committer line - bad time zone > warning in commit e7a751a597c6f5e4770c61bdee6220d55a37cba9: badTimezone: invalid author/committer line - bad time zone > warning in commit 3e32ad6192fe093e03e6b9346c3a90b16d9905c0: badTimezone: invalid author/committer line - bad time zone > warning in commit 5e66b47528e79d3bbb769e137f036a1fa99cccf9: badTimezone: invalid author/committer line - bad time zone > warning in commit d90d67d94ca47142670dff13fcb81ab7afab07bb: badTimezone: invalid author/committer line - bad time zone > Checking objects: 100% (1711464/1711464), done. > Checking connectivity: 1711464, done. git fsck on lkml/git/1.git reports: > Checking object directories: 100% (256/256), done. > warning in commit 299dbd50b6995c6debe2275f0df984ce697fb4cc: nulInCommit: NUL byte in the commit object body > Checking objects: 100% (1427013/1427013), done. git fsck on lkml/git/2.git reports: > Checking object directories: 100% (256/256), done. > warning in commit 696b4d4e94dfc2c4a8518f642879ed74bc415ecd: badTimezone: invalid author/committer line - bad time zone > Checking objects: 100% (1366098/1366098), done. Eric