From: ebiederm@xmission.com (Eric W. Biederman)
To: <meta@public-inbox.org>
Cc: Eric Wong <e@80x24.org>
Subject: Warnings from git fsck after lkml import
Date: Thu, 05 Jul 2018 00:40:45 -0500 [thread overview]
Message-ID: <87a7r6z1cy.fsf@xmission.com> (raw)
It looks like public-inbox has some challenges when importing some
questionable emails. The import of lkml has resulted in several commits
with bad dates that git fsck complains about. I have previously
reported this to Konstantin Ryabitsev who maintains kernel.org but since
I have not seen any discussion of this I thought I should report it
directly here as well.
At a practical level these errors initially preventing me from cloning
the repos as in .gitconfig I had:
> [transfer]
> fsckobjects = true
> [fetch]
> fsckobjects = true
> [receive]
> fsckobjects = true
Beyond the cloning issue while I don't expect public-inbox to fix the
emails themselves it should be able to detect and prevent creating
buggy commits.
Importing a large repo like linux-kernel seems like a good test case for
finding these kinds of issues.
git fsck on lkml/git/0.git reports:
> Checking object directories: 100% (256/256), done.
> warning in commit 59173dc1fe67b113ace4ce83e7f522414b3e0404: badTimezone: invalid author/committer line - bad time zone
> warning in commit ff22aaff22eb4479e49e93f697e385f76db51c55: badTimezone: invalid author/committer line - bad time zone
> warning in commit 609b744909693f5f00aff5ed9928beeeee9ded2e: badTimezone: invalid author/committer line - bad time zone
> warning in commit 084572141db8e0d879428afb278bd338f2dbb053: badTimezone: invalid author/committer line - bad time zone
> warning in commit 789d204de27cd12c6da693d903390a241a1a4bca: badTimezone: invalid author/committer line - bad time zone
> warning in commit 0d9a65948b0c957007ca387cd56b690f9bab9c08: badTimezone: invalid author/committer line - bad time zone
> warning in commit f7468c42b4196ee6323afb373ab9323971c38d69: badTimezone: invalid author/committer line - bad time zone
> warning in commit 85e0cd6dd527cd55ad0440f14384529b83818228: badTimezone: invalid author/committer line - bad time zone
> warning in commit f31e19a2e772c9ed00728ef142af9c550ea5de6a: badTimezone: invalid author/committer line - bad time zone
> warning in commit 56eb7384443ef84e17e29504a304a071b189ae67: badTimezone: invalid author/committer line - bad time zone
> warning in commit e4470030471e6810414b9de5e3b52e16f2245d12: badTimezone: invalid author/committer line - bad time zone
> warning in commit f913b48caa097c3b2cb3f491707944f88d52d89f: badTimezone: invalid author/committer line - bad time zone
> warning in commit 4390f26923d572c6dab6cce8282c7cad5520d785: badTimezone: invalid author/committer line - bad time zone
> warning in commit 0f66db71a06bd7d651a0cd80877d8043b70fda20: badTimezone: invalid author/committer line - bad time zone
> warning in commit d71472c40b36dcdf0396afc9778f6137eea45887: badTimezone: invalid author/committer line - bad time zone
> warning in commit e8d3b19a91a2d86b6a91bd19dc811e851398b519: badTimezone: invalid author/committer line - bad time zone
> warning in commit afd9fc0cc87e56ed7736d633e17d0ef77817b3cc: badTimezone: invalid author/committer line - bad time zone
> warning in commit 811b3217708358cf1b75fba4602a64a426fce0f5: badTimezone: invalid author/committer line - bad time zone
> warning in commit e7a751a597c6f5e4770c61bdee6220d55a37cba9: badTimezone: invalid author/committer line - bad time zone
> warning in commit 3e32ad6192fe093e03e6b9346c3a90b16d9905c0: badTimezone: invalid author/committer line - bad time zone
> warning in commit 5e66b47528e79d3bbb769e137f036a1fa99cccf9: badTimezone: invalid author/committer line - bad time zone
> warning in commit d90d67d94ca47142670dff13fcb81ab7afab07bb: badTimezone: invalid author/committer line - bad time zone
> Checking objects: 100% (1711464/1711464), done.
> Checking connectivity: 1711464, done.
git fsck on lkml/git/1.git reports:
> Checking object directories: 100% (256/256), done.
> warning in commit 299dbd50b6995c6debe2275f0df984ce697fb4cc: nulInCommit: NUL byte in the commit object body
> Checking objects: 100% (1427013/1427013), done.
git fsck on lkml/git/2.git reports:
> Checking object directories: 100% (256/256), done.
> warning in commit 696b4d4e94dfc2c4a8518f642879ed74bc415ecd: badTimezone: invalid author/committer line - bad time zone
> Checking objects: 100% (1366098/1366098), done.
Eric
next reply other threads:[~2018-07-05 5:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 5:40 Eric W. Biederman [this message]
2018-07-05 23:13 ` Warnings from git fsck after lkml import Eric Wong
2018-07-06 0:36 ` Eric W. Biederman
2018-07-06 3:47 ` Eric W. Biederman
2018-07-06 21:32 ` [PATCH] MsgTime.pm: Use strptime to compute the time zone Eric W. Biederman
2018-07-06 22:22 ` Eric Wong
2018-07-07 18:18 ` Eric W. Biederman
2018-07-07 18:22 ` [PATCH] Import: Don't copy nulls from emails into git Eric W. Biederman
2018-07-08 0:07 ` Eric Wong
2018-07-08 1:52 ` Eric W. Biederman
2018-07-12 18:31 ` Warnings from git fsck after lkml import Konstantin Ryabitsev
2018-07-12 22:19 ` Eric W. Biederman
2018-07-12 22:29 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7r6z1cy.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).