From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS6315 166.70.0.0/16 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_LOW,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EC5C51F597; Thu, 19 Jul 2018 20:48:35 +0000 (UTC) Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fgFql-0004If-5C; Thu, 19 Jul 2018 14:48:35 -0600 Received: from [97.119.167.31] (helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fgFqk-00046L-JZ; Thu, 19 Jul 2018 14:48:34 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Eric Wong Cc: meta@public-inbox.org References: <87zhyndnls.fsf@xmission.com> <20180719204457.mbnklcamdklhnjmr@whir> Date: Thu, 19 Jul 2018 15:48:27 -0500 In-Reply-To: <20180719204457.mbnklcamdklhnjmr@whir> (Eric Wong's message of "Thu, 19 Jul 2018 20:44:57 +0000") Message-ID: <87a7qndk9w.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1fgFqk-00046L-JZ;;;mid=<87a7qndk9w.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=97.119.167.31;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+d4RtFRcV6yMgA5C/1cEu3uOYg59Qm40A= X-SA-Exim-Connect-IP: 97.119.167.31 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH] Import.pm: Deal with potentially missing From and Sender headers X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) List-Id: Eric Wong writes: > "Eric W. Biederman" wrote: >> >> Use ||= '' to ensure that if the From or Sender header is not present >> the code sees an empty string and instead of undefined. >> >> I had some email messages with a From field without an @ (because the >> sender was local) and without a Sender which were causing errors when >> imported. I think this was bad enough that the email messages were >> failing to be imported. > > Thanks, pushed to master as ce5af2029b6bc703f3d8cf7bb5c68732c41f210e. > > I assume this is from testing against personal mail? > I haven't tried that, yet :x It is. So far just importing my personal mail. Eric