user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: (Eric W. Biederman)
To: Eric Wong <>
Subject: Re: [PATCH] t/import: test for nasty characters
Date: Sat, 04 Jul 2020 15:28:34 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20200704202525.GA19556@dcvr> (Eric Wong's message of "Sat, 4 Jul 2020 20:25:25 +0000")

Eric Wong <> writes:

> Eric Wong <> wrote:
>> "Eric W. Biederman" <> wrote:
>> > -		$name =~ tr/<>//d;
>> > +		$name =~ tr/\n\r<>$/     /d;
>> Is getting rid of '$' an effort to avoid double interpolation by Perl?
>> Perl won't recursively expand variables AFAIK.
> I'm not seeing the purpose in $ being grouped with the
> characters (test below confirms it, I think).

What I think we should be doing is any characters that are not a valid
part of a name (as defined by the appropriate email RFCs) should be
dealt with.

I am pretty certain $ isn't of those characters that is valid in a name.

Otherwise I suspect this will be a game of whack-a-mole as new weird
and strange cases crop up.  Maybe I am just paranoid, but right now
the code seems a bit too liberal in what it accepts.


  reply	other threads:[~2020-07-04 20:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 21:53 [PATCH] Import: Be more careful with names in email Eric W. Biederman
2020-07-03 23:30 ` Eric Wong
2020-07-04 20:25   ` [PATCH] t/import: test for nasty characters Eric Wong
2020-07-04 20:28     ` Eric W. Biederman [this message]
2020-07-04 21:24       ` Eric Wong
2020-07-05 14:55       ` Leah Neukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).