user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] test_common: fix require_git skip message
@ 2025-03-22 20:55 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2025-03-22 20:55 UTC (permalink / raw)
  To: meta

We need to use `sprintf("%vd")' to format the required version
v-string for human consumption.
---
 lib/PublicInbox/TestCommon.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index 162cefed..ec54e2f1 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -161,9 +161,10 @@ sub require_git ($;$) {
 
 	return 1 if $cur_vstr ge $req;
 	state $cur_ver = sprintf('%vd', $cur_vstr);
-	return plan skip_all => "git $req+ required, have $cur_ver" if !$nr;
+	my $vreq = sprintf('%vd', $req);
+	return plan skip_all => "git $vreq+ required, have $cur_ver" if !$nr;
 	defined(wantarray) ? undef :
-		skip("git $req+ required (have $cur_ver)", $nr)
+		skip("git $vreq+ required (have $cur_ver)", $nr)
 }
 
 sub require_git_http_backend (;$) {

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2025-03-22 20:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-22 20:55 [PATCH] test_common: fix require_git skip message Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).