user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [SQUASH 3/2] plack_limiter: fix error response
Date: Sat, 22 Mar 2025 10:18:57 +0000	[thread overview]
Message-ID: <20250322101857.M382453@dcvr> (raw)
In-Reply-To: <20250321222231.3276910-3-e@80x24.org>

We still need to remember to call the write callback we captured
from the PSGI server to avoid leaving sockets open indefinitely
with no response.
---
 lib/PublicInbox/PlackLimiter.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/PlackLimiter.pm b/lib/PublicInbox/PlackLimiter.pm
index 2ca0a63f..48039212 100644
--- a/lib/PublicInbox/PlackLimiter.pm
+++ b/lib/PublicInbox/PlackLimiter.pm
@@ -15,9 +15,9 @@ sub prepare_app { # called via Plack::Component (used by Plack::Middleware)
 }
 
 sub lim_fail { # limiter->may_start fail_cb
-	my (undef, $code, $msg) = @_;
-	[ $code, [ 'Content-Type' => 'text/plain',
-		'Content-Length' => length($msg) ], [ $msg ] ]
+	my ($ctx, $code, $msg) = @_;
+	delete($ctx->{psgi_wcb})->([ $code, [ 'Content-Type' => 'text/plain',
+		'Content-Length' => length($msg) ], [ $msg ] ]);
 }
 
 sub stats ($) {

      reply	other threads:[~2025-03-22 10:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21 22:22 [PATCH 0/2] limiter logic deduplication Eric Wong
2025-03-21 22:22 ` [PATCH 1/2] qspawn: rename {psgi_env} => {env} Eric Wong
2025-03-21 22:22 ` [PATCH 2/2] limiter: refactor to reduce code duplication Eric Wong
2025-03-22 10:18   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250322101857.M382453@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).