From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/2] qspawn: rename {psgi_env} => {env}
Date: Fri, 21 Mar 2025 22:22:29 +0000 [thread overview]
Message-ID: <20250321222231.3276910-2-e@80x24.org> (raw)
In-Reply-To: <20250321222231.3276910-1-e@80x24.org>
There's no need to make a distinction here, and
it will help us make the limiter code more flexible
and reusable in next commits.
---
lib/PublicInbox/Qspawn.pm | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index 34e9eff6..b882ea53 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -88,7 +88,7 @@ sub _finalize ($) {
warn "E: @{$self->{args}->[0]}: $err\n" if !$self->{-quiet};
}
- my ($env, $qx_cb_arg) = delete @$self{qw(psgi_env qx_cb_arg)};
+ my ($env, $qx_cb_arg) = delete @$self{qw(env qx_cb_arg)};
if ($qx_cb_arg) {
my $cb = shift @$qx_cb_arg;
eval { $cb->($self->{args}->[2]->{1}, @$qx_cb_arg) };
@@ -161,8 +161,8 @@ sub start ($$$) {
if ($limiter->{running} < $limiter->{max}) {
_do_spawn($self, $start_cb, $limiter);
} elsif ($limiter->is_too_busy) {
- $self->{psgi_env}->{'qspawn.fallback'} //= 503 if
- $self->{psgi_env};
+ $self->{env}->{'qspawn.fallback'} //= 503 if
+ $self->{env};
_finalize $self;
} else {
push @{$limiter->{run_queue}}, [ $self, $start_cb ];
@@ -175,7 +175,7 @@ sub start ($$$) {
# and safe to slurp.
sub psgi_qx {
my ($self, $env, $limiter, @qx_cb_arg) = @_;
- $self->{psgi_env} = $env;
+ $self->{env} = $env;
$self->{qx_cb_arg} = \@qx_cb_arg;
$limiter ||= $def_limiter ||= PublicInbox::Limiter->new;
start($self, $limiter, undef);
@@ -183,7 +183,7 @@ sub psgi_qx {
sub yield_pass {
my ($self, $ipipe, $res) = @_; # $ipipe = InputPipe
- my $env = $self->{psgi_env};
+ my $env = $self->{env};
my $wcb = delete $env->{'qspawn.wcb'} // confess('BUG: no qspawn.wcb');
if (ref($res) eq 'CODE') { # chain another command
delete $self->{rpipe};
@@ -232,7 +232,7 @@ sub parse_hdr_done ($$) {
$ret = psgi_status_err();
}
carp <<EOM if $err;
-E: $err @{$self->{args}->[0]} ($self->{psgi_env}->{REQUEST_URI})
+E: $err @{$self->{args}->[0]} ($self->{env}->{REQUEST_URI})
EOM
$ret; # undef if headers incomplete
}
@@ -248,7 +248,7 @@ sub ipipe_cb { # InputPipe callback
sub _yield_start { # may run later, much later...
my ($self) = @_;
- if ($self->{psgi_env}->{'pi-httpd.async'}) {
+ if ($self->{env}->{'pi-httpd.async'}) {
my $rpipe = $self->{rpipe};
PublicInbox::InputPipe::consume($rpipe, \&ipipe_cb, $self);
} else {
@@ -283,7 +283,7 @@ sub _yield_start { # may run later, much later...
sub psgi_yield {
my ($self, $env, $limiter, @parse_hdr_arg)= @_;
- $self->{psgi_env} = $env;
+ $self->{env} = $env;
$self->{yield_parse_hdr} = [ \(my $buf = ''), @parse_hdr_arg ];
$limiter ||= $def_limiter ||= PublicInbox::Limiter->new;
next prev parent reply other threads:[~2025-03-21 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 22:22 [PATCH 0/2] limiter logic deduplication Eric Wong
2025-03-21 22:22 ` Eric Wong [this message]
2025-03-21 22:22 ` [PATCH 2/2] limiter: refactor to reduce code duplication Eric Wong
2025-03-22 10:18 ` [SQUASH 3/2] plack_limiter: fix error response Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250321222231.3276910-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).