user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 5/5] net_reader: improve IMAP error reporting
Date: Wed, 14 Aug 2024 00:16:45 +0000	[thread overview]
Message-ID: <20240814001645.395576-6-e@80x24.org> (raw)
In-Reply-To: <20240814001645.395576-1-e@80x24.org>

IMAPClient->LastError provides information that isn't an errno
(`$!'), so use it to tell us about anything the server reports
back.
---
 lib/PublicInbox/NetReader.pm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm
index ec18818b..7e861f5f 100644
--- a/lib/PublicInbox/NetReader.pm
+++ b/lib/PublicInbox/NetReader.pm
@@ -570,7 +570,8 @@ sub each_old_flags ($$$$) {
 		my $r = $mic->fetch_hash("$n:$end", 'FLAGS');
 		if (!$r) {
 			return if $!{EINTR} && $self->{quit};
-			return "E: $uri UID FETCH $n:$end error: $!";
+			return "E: $uri UID FETCH $n:$end error: " .
+				$mic->LastError." \$!=$!"
 		}
 		while (my ($uid, $per_uid) = each %$r) {
 			my $kw = flags2kw($self, $uri, $uid, $per_uid->{FLAGS})
@@ -699,7 +700,8 @@ EOF
 			$uids = [ $single_uid ];
 		} elsif (!($uids = $mic->search("UID $l_uid:*"))) {
 			return if $!{EINTR} && $self->{quit};
-			return "E: $uri UID SEARCH $l_uid:* error: $!";
+			return "E: $uri UID SEARCH $l_uid:* error: ".
+				$mic->LastError." \$!=$!"
 		}
 		return if scalar(@$uids) == 0;
 

  parent reply	other threads:[~2024-08-14  0:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14  0:16 [PATCH 0/5] lei import-related fixes + diagnostics Eric Wong
2024-08-14  0:16 ` [PATCH 1/5] git: rename `_active' sub to `cat_active' Eric Wong
2024-08-14  0:16 ` [PATCH 2/5] lei_store: use autodie for open+close Eric Wong
2024-08-14  0:16 ` [PATCH 3/5] v2writable: confess on broken {idx_shards} Eric Wong
2024-08-14  0:16 ` [PATCH 4/5] lei_search: make missing Xapian docs for kw lookups Eric Wong
2024-08-14  0:16 ` Eric Wong [this message]
2024-11-19 21:51 ` [PATCH 0/5] lei import-related fixes + diagnostics Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240814001645.395576-6-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).