From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 4/5] lei_search: make missing Xapian docs for kw lookups
Date: Wed, 14 Aug 2024 00:16:44 +0000 [thread overview]
Message-ID: <20240814001645.395576-5-e@80x24.org> (raw)
In-Reply-To: <20240814001645.395576-1-e@80x24.org>
Missing keyword entries should be non-fatal since Xapian
data is always less important than what's in git and SQLite.
As such, Xapian data has and remains written last, leaving
the possibility of documents being missing from Xapian but
present in SQLite and git.
This improves recovery dealing with badly interrupted or failed
imports due to bugs or hardware failures.
---
lib/PublicInbox/LeiSearch.pm | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/LeiSearch.pm b/lib/PublicInbox/LeiSearch.pm
index 684668c5..4519306d 100644
--- a/lib/PublicInbox/LeiSearch.pm
+++ b/lib/PublicInbox/LeiSearch.pm
@@ -145,7 +145,15 @@ sub kw_changed {
}
if (!defined($cur_kw) && $@) {
$docids = join(', num:', @$docids);
- croak "E: num:$docids keyword lookup failure: $@";
+ # this may happen if a previous import was incomplete since
+ # we commit changes to Xapian last
+ if (ref($@) =~ /::DocNotFoundError\b/) {
+ warn <<EOM;
+W: num:$docids keyword lookup failure, assuming no keywords
+EOM
+ } else {
+ croak "E: num:$docids keyword lookup failure: $@";
+ }
}
# RFC 5550 sec 5.9 on the $Forwarded keyword states:
# "Once set, the flag SHOULD NOT be cleared"
next prev parent reply other threads:[~2024-08-14 0:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 0:16 [PATCH 0/5] lei import-related fixes + diagnostics Eric Wong
2024-08-14 0:16 ` [PATCH 1/5] git: rename `_active' sub to `cat_active' Eric Wong
2024-08-14 0:16 ` [PATCH 2/5] lei_store: use autodie for open+close Eric Wong
2024-08-14 0:16 ` [PATCH 3/5] v2writable: confess on broken {idx_shards} Eric Wong
2024-08-14 0:16 ` Eric Wong [this message]
2024-08-14 0:16 ` [PATCH 5/5] net_reader: improve IMAP error reporting Eric Wong
2024-11-19 21:51 ` [PATCH 0/5] lei import-related fixes + diagnostics Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814001645.395576-5-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).