From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/4] search: remove auto-start for async_mset
Date: Fri, 26 Apr 2024 11:29:42 +0000 [thread overview]
Message-ID: <20240426112944.1528532-3-e@80x24.org> (raw)
In-Reply-To: <20240426112944.1528532-1-e@80x24.org>
Only public-facing daemons use it, currently, and all
public-facing daemons will pre-spawn it as early as feasible.
lei will need it eventually to handle queries requiring C++,
but I'm not certain what path to take with lei, yet...
---
lib/PublicInbox/Search.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index 4adef366..fbdb48a3 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -465,7 +465,6 @@ sub xh_opt ($) {
# and a falsy value if handled synchronously
sub async_mset {
my ($self, $qry_str, $opt, $cb, @args) = @_;
- $XHC //= xhc_start_maybe;
if ($XHC) { # unconditionally retrieving pct + rank for now
xdb($self); # populate {nshards}
my @margs = ($self->xh_args, xh_opt($opt));
next prev parent reply other threads:[~2024-04-26 11:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 11:29 [PATCH 0/4] more xap_helper updates Eric Wong
2024-04-26 11:29 ` [PATCH 1/4] test_common: don't needlessly rebuild C++ Xapian helper Eric Wong
2024-04-26 11:29 ` Eric Wong [this message]
2024-04-26 11:29 ` [PATCH 3/4] xap_helper: reopen logs in daemons Eric Wong
2024-04-26 11:29 ` [PATCH 4/4] xap_helper: implement alarm(2)-based timeout Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426112944.1528532-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).