user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/2] codesearch: generate_cxx: drop unused variables
Date: Mon, 12 Feb 2024 21:28:04 +0000	[thread overview]
Message-ID: <20240212212804.3465667-3-e@80x24.org> (raw)
In-Reply-To: <20240212212804.3465667-1-e@80x24.org>

We are just using the odd ref+deref (`${\...}') syntax and
don't need to calculate line numbers ourselves, nowadays.
---
 lib/PublicInbox/CodeSearch.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/PublicInbox/CodeSearch.pm b/lib/PublicInbox/CodeSearch.pm
index 48697cdc..1f95a726 100644
--- a/lib/PublicInbox/CodeSearch.pm
+++ b/lib/PublicInbox/CodeSearch.pm
@@ -101,7 +101,6 @@ sub qparse_new ($) {
 }
 
 sub generate_cxx () { # generates snippet for xap_helper.h
-	my ($line, $file) = (__LINE__ + 2, __FILE__);
 	my $ret = <<EOM;
 # line ${\__LINE__} "${\__FILE__}"
 static NRP *code_nrp[${\scalar(@CODE_VMAP)}];

      parent reply	other threads:[~2024-02-12 21:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 21:28 [PATCH 0/2] xap_helper C++ fixes Eric Wong
2024-02-12 21:28 ` [PATCH 1/2] xap_helper_cxx: -O2 optimize read-only files by default Eric Wong
2024-02-12 21:28 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240212212804.3465667-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).