From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] www: quiet errors for git-{archive,http-backend}
Date: Fri, 9 Feb 2024 17:37:05 +0000 [thread overview]
Message-ID: <20240209173705.3196374-1-e@80x24.org> (raw)
SIGPIPE (13) can be quite common with unreliable connections
and impatient clients, so just ignore them.
---
lib/PublicInbox/GitHTTPBackend.pm | 1 +
lib/PublicInbox/RepoSnapshot.pm | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 7228555b..396aa783 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -105,6 +105,7 @@ sub serve_smart {
$env{GIT_HTTP_EXPORT_ALL} = '1';
$env{PATH_TRANSLATED} = "$git->{git_dir}/$path";
my $rdr = input_prepare($env) or return r(500);
+ $rdr->{quiet} = 1;
my $qsp = PublicInbox::Qspawn->new([qw(git http-backend)], \%env, $rdr);
$qsp->psgi_yield($env, $limiter, \&ghb_parse_hdr, $env, $git, $path);
}
diff --git a/lib/PublicInbox/RepoSnapshot.pm b/lib/PublicInbox/RepoSnapshot.pm
index 6b7441b0..4c372569 100644
--- a/lib/PublicInbox/RepoSnapshot.pm
+++ b/lib/PublicInbox/RepoSnapshot.pm
@@ -57,7 +57,8 @@ sub ver_check { # git->check_async callback
my $qsp = PublicInbox::Qspawn->new(['git', @cfg,
"--git-dir=$ctx->{git}->{git_dir}", 'archive',
"--prefix=$ctx->{snap_pfx}/",
- "--format=$ctx->{snap_fmt}", $treeish]);
+ "--format=$ctx->{snap_fmt}", $treeish], undef,
+ { quiet => 1 });
$qsp->psgi_yield($ctx->{env}, undef, \&archive_hdr, $ctx);
}
}
reply other threads:[~2024-02-09 17:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209173705.3196374-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).