From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
	T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no
	version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 869DB1F406;
	Sat, 25 Nov 2023 00:00:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1700870458;
	bh=/6I2mT/dKTEY3VNMc46eyG5zDa09VDyeyDpDD2pfo7c=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=JceBj6tFdf6B6ZdJlf+JelltY6UFbTu29jtteP1IlvMjQxA86I1I6n24OxJ32cHTW
	 PT+kBGfj1djfIX/h5B+zosKFMSjRs/T4JGf0V7jcf1YJWhVKxJT3vqkf3jC2WWP7y6
	 V35bsc0uEiDyg24LbpNpKa5Kldd3s5XSyVMGGSK4=
Date: Fri, 24 Nov 2023 23:58:29 +0000
From: Eric Wong <e@80x24.org>
To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= <stepnem@smrk.net>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] doc/extindex: document --dedupe switch
Message-ID: <20231124235829.M382392@dcvr>
References: <20231124041819.1979651-1-e@80x24.org>
 <20231124135059+0100.879284-stepnem@smrk.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231124135059+0100.879284-stepnem@smrk.net>
List-Id: <meta.public-inbox.org>

Štěpán Němec <stepnem@smrk.net> wrote:
> Eric Wong wrote:
> > +++ b/Documentation/public-inbox-extindex.pod
> > @@ -47,6 +47,20 @@ C<indexlevel> set to C<basic> and their respective Xapian
> >  public-inboxes where cross-posting is common, this allows
> >  significant space savings on Xapian indices.
> >  
> > +=item --dedupe=MSGID
> > +
> > +=item --dedupe
> > +
> > +Rerun deduplication on messages of a Message-IDs or all messages
>                                    ^^^^^^^^^^^^^^^^
> "with the given Message-ID"?  (or just drop the trailing "s")

Yes, the former, thanks.

I'm also wondering if it's necessary to have a blurb about NOT
supporting comma-delimited Message-IDs on the CLI, since some
strange Message-IDs may have a comma in them.

Anyways, I'll squash something like this in:

diff --git a/Documentation/public-inbox-extindex.pod b/Documentation/public-inbox-extindex.pod
index 361eb43f..3a2911e2 100644
--- a/Documentation/public-inbox-extindex.pod
+++ b/Documentation/public-inbox-extindex.pod
@@ -51,9 +51,9 @@ significant space savings on Xapian indices.
 
 =item --dedupe
 
-Rerun deduplication on messages of a Message-IDs or all messages
-if no Message-ID is specified.  Deduplication rules may change
-and evolve over time, especially if filters are involved.
+Rerun deduplication on messages of with the given Message-ID or
+all messages if no Message-ID is specified.  Deduplication rules may
+change and evolve over time, especially if filters are involved.
 
 C<--dedupe=MSGID> may be specified multiple times to deduplicate
 multiple Message-IDs.