From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id DB1661F406 for ; Mon, 20 Nov 2023 07:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1700465949; bh=pbgk2yJcvP0yQcj3IxynLklZIxAzlEInlGuvBU7NwOA=; h=From:To:Subject:Date:From; b=Wq8/jlnoFOATDmbCSmqcRUT6JHzCrlTBCGvQbaz8prucr9vMYx3tnuyo0pXY/PNnk 8Q7st+38UVP3CGuY2sRZ9imsnY1WLfMJRc33I1bSUwHoIFh2cREFdFQWkPjzybTpDf yh4K4vMry3Y4OprdZh9VNrqGPJp+PUo4iEfsfTbY= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] test_common: fix excessive wait for GNU tail inotify Date: Mon, 20 Nov 2023 07:39:09 +0000 Message-ID: <20231120073909.3332202-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We want to use the filenames tail will watch, not the number of args passed to the `tail_f' subroutine. Fixes: 9231d2e7b93f (tests: map CLOFORK->FD_CLOEXEC temporarily for `tail -f') --- lib/PublicInbox/TestCommon.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm index 8bfa30f2..0d17e6e7 100644 --- a/lib/PublicInbox/TestCommon.pm +++ b/lib/PublicInbox/TestCommon.pm @@ -512,7 +512,7 @@ sub tail_f (@) { while (my ($io, $fl) = splice(@cfmap, 0, 2)) { fcntl($io, F_SETFD, $fl); } - wait_for_tail($pid, scalar @_); + wait_for_tail($pid, scalar @f); require PublicInbox::AutoReap; PublicInbox::AutoReap->new($pid, \&wait_for_tail); }