From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A701F1F406 for ; Thu, 2 Nov 2023 09:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1698917740; bh=iDDt+ZITo58lKmw6L551Ye+Z+Y6Wi6HsIdxfz98L6Wg=; h=From:To:Subject:Date:From; b=j/sRF0+NilVWBsVKV29HoJFZRRnba+Q688sdJU/ll08pQiRTzptZOMO4VBhy6GBqb SJBr/2o9l1/P9uhDvjh3+0YPKY44gVefJphOj+ysXuS7PmsGQ3aNgCQJyEXxOEsKga N3SfjOuo1JiMpTXr70TP3GuINHrP1pN4UiGuXJ50= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 00/14] IO/IPC-related cleanups Date: Thu, 2 Nov 2023 09:35:25 +0000 Message-Id: <20231102093539.2067470-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: 8/14 to replace ProcessIO is a major change that I've been hammering away at for a bit, and many preceding patches to eliminate ->close calls make it easier to review. 11-12/14 - Error checking for buffered readline is a PITA (IO::Handle->error was insufficient until Perl 5.34), and I may switch to sysread eventually to avoid the double-copy overhead of buffered bulk I/O, anyways. The only place we really benefit from userspace buffered disk reads is IdxStack, I think... The new write_file sub in 9/14 seems long overdue. Eric Wong (14): xap_helper.pm: use do_fork to Reset and reseed ds: replace FD map hash table with array treewide: use ->close method rather than CORE::close cindex: drop redundant close on regular FH treewide: use ->close to call ProcessIO->CLOSE multi_git: use autodie git_credential: use autodie where appropriate replace ProcessIO with untied PublicInbox::IO io: introduce write_file helper sub spawn: support PerlIO layer in scalar redirects treewide: check alternates writes with eof + autodie treewide: use eof and close to detect readline errors move read_all, try_cat, and poll_in to PublicInbox::IO t/cindex+extsearch: use write_file, autodie, etc. MANIFEST | 4 +- lib/PublicInbox/CodeSearchIdx.pm | 14 +++--- lib/PublicInbox/Config.pm | 2 +- lib/PublicInbox/DS.pm | 22 ++++----- lib/PublicInbox/DirIdle.pm | 2 +- lib/PublicInbox/Gcf2.pm | 4 +- lib/PublicInbox/Gcf2Client.pm | 7 ++- lib/PublicInbox/Git.pm | 36 ++++---------- lib/PublicInbox/GitCredential.pm | 16 +++---- lib/PublicInbox/HTTP.pm | 4 +- lib/PublicInbox/IO.pm | 80 ++++++++++++++++++++++++++++++++ lib/PublicInbox/IdxStack.pm | 2 +- lib/PublicInbox/Import.pm | 18 ++++--- lib/PublicInbox/Inbox.pm | 2 +- lib/PublicInbox/InboxWritable.pm | 2 +- lib/PublicInbox/InputPipe.pm | 1 - lib/PublicInbox/LEI.pm | 8 ++-- lib/PublicInbox/LeiALE.pm | 6 +-- lib/PublicInbox/LeiBlob.pm | 3 +- lib/PublicInbox/LeiConfig.pm | 2 +- lib/PublicInbox/LeiInput.pm | 5 +- lib/PublicInbox/LeiMailSync.pm | 3 +- lib/PublicInbox/LeiMirror.pm | 57 +++++++++-------------- lib/PublicInbox/LeiRediff.pm | 11 ++--- lib/PublicInbox/LeiStoreErr.pm | 2 +- lib/PublicInbox/LeiSucks.pm | 2 +- lib/PublicInbox/LeiToMail.pm | 34 +++++++------- lib/PublicInbox/LeiViewText.pm | 2 +- lib/PublicInbox/LeiXSearch.pm | 8 ++-- lib/PublicInbox/MailDiff.pm | 21 ++++----- lib/PublicInbox/MboxReader.pm | 4 +- lib/PublicInbox/MultiGit.pm | 13 +++--- lib/PublicInbox/ProcessIO.pm | 75 ------------------------------ lib/PublicInbox/ProcessIONBF.pm | 25 ---------- lib/PublicInbox/Qspawn.pm | 5 +- lib/PublicInbox/SearchIdx.pm | 4 +- lib/PublicInbox/SolverGit.pm | 38 ++++++--------- lib/PublicInbox/Spawn.pm | 42 ++++++++++------- lib/PublicInbox/TestCommon.pm | 4 +- lib/PublicInbox/V2Writable.pm | 2 +- lib/PublicInbox/ViewVCS.pm | 6 +-- lib/PublicInbox/WWW.pm | 2 +- lib/PublicInbox/XapHelper.pm | 14 ++---- lib/PublicInbox/XapHelperCxx.pm | 3 +- script/public-inbox-convert | 6 +-- script/public-inbox-edit | 3 +- script/public-inbox-init | 4 +- t/cindex.t | 17 ++----- t/clone-coderepo.t | 10 ++-- t/extsearch.t | 48 ++++++------------- t/httpd-corner.t | 2 +- t/init.t | 2 +- t/io.t | 33 +++++++++++++ t/lei-mirror.t | 10 ++-- t/lei-q-kw.t | 4 +- t/spawn.t | 36 +++++++------- xt/check-run.t | 2 +- xt/git_async_cmp.t | 4 +- xt/httpd-async-stream.t | 2 +- 59 files changed, 368 insertions(+), 432 deletions(-) create mode 100644 lib/PublicInbox/IO.pm delete mode 100644 lib/PublicInbox/ProcessIO.pm delete mode 100644 lib/PublicInbox/ProcessIONBF.pm create mode 100644 t/io.t