From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 06/26] qspawn: drop unused err arg for ->event_step
Date: Wed, 25 Oct 2023 00:29:29 +0000 [thread overview]
Message-ID: <20231025002949.3092193-7-e@80x24.org> (raw)
In-Reply-To: <20231025002949.3092193-1-e@80x24.org>
It's no longer needed since psgi_qx doesn't use a pipe, anymore.
---
lib/PublicInbox/Qspawn.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index 0f900691..9a7e8734 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -163,8 +163,7 @@ sub psgi_qx {
# via PublicInbox::DS event loop OR via GetlineBody for generic
# PSGI servers.
sub event_step {
- my ($self, $err) = @_; # $err: $!
- warn "psgi_{return,qx} $err" if defined($err);
+ my ($self) = @_;
finish($self);
my $fh = delete $self->{qfh};
$fh->close if $fh; # async-only (psgi_return)
next prev parent reply other threads:[~2023-10-25 0:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 0:29 [PATCH 00/26] process management simplifications Eric Wong
2023-10-25 0:29 ` [PATCH 01/26] limiter: split out from qspawn Eric Wong
2023-10-25 0:29 ` [PATCH 02/26] spawn: support synchronous run_qx Eric Wong
2023-10-25 0:29 ` [PATCH 03/26] psgi_qx: use a temporary file rather than pipe Eric Wong
2023-10-25 0:29 ` [PATCH 04/26] www_coderepo: capture uses a flattened list Eric Wong
2023-10-25 0:29 ` [PATCH 05/26] qspawn: psgi_return allows list for callback args Eric Wong
2023-10-25 0:29 ` Eric Wong [this message]
2023-10-25 0:29 ` [PATCH 07/26] httpd/async: require IO arg Eric Wong
2023-10-25 0:29 ` [PATCH 08/26] xt/check-run: call DS->Reset after all tests Eric Wong
2023-10-25 0:29 ` [PATCH 09/26] qspawn: introduce new psgi_yield API Eric Wong
2023-10-25 0:29 ` [PATCH 10/26] repo_atom: switch to psgi_yield Eric Wong
2023-10-25 0:29 ` [PATCH 11/26] repo_snapshot: psgi_yield Eric Wong
2023-10-25 0:29 ` [PATCH 12/26] viewvcs: psgi_yield Eric Wong
2023-10-25 0:29 ` [PATCH 13/26] www_altid: switch to psgi_yield Eric Wong
2023-10-25 0:29 ` [PATCH 14/26] cgit: " Eric Wong
2023-10-25 0:29 ` [PATCH 15/26] www_coderepo: use psgi_yield Eric Wong
2023-10-25 0:29 ` [PATCH 16/26] drop psgi_return, httpd/async and GetlineBody Eric Wong
2023-10-25 0:29 ` [PATCH 17/26] qspawn: use WwwStatic for fallbacks and error code Eric Wong
2023-10-25 0:29 ` [PATCH 18/26] qspawn: simplify internal argument passing Eric Wong
2023-10-25 0:29 ` [PATCH 19/26] cidx_log_p: don't bother with F_SETPIPE_SZ Eric Wong
2023-10-25 0:29 ` [PATCH 20/26] cindex: avoid awaitpid for popen Eric Wong
2023-10-25 0:29 ` [PATCH 21/26] cindex: use timer for inits Eric Wong
2023-10-25 0:29 ` [PATCH 22/26] cindex: start using run_await to simplify code Eric Wong
2023-10-25 0:29 ` [PATCH 23/26] cindex: use run_await to read extensions.objectFormat Eric Wong
2023-10-25 0:29 ` [PATCH 24/26] cindex: drop XH_PID global Eric Wong
2023-10-25 0:29 ` [PATCH 25/26] cindex: use run_await wrapper for git commands Eric Wong
2023-10-25 0:29 ` [PATCH 26/26] cindex: use sysread for generating fingerprint Eric Wong
2023-10-25 6:33 ` [PATCH 27/26] lei_mirror+fetch: don't slurp `git show-ref' output Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025002949.3092193-7-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).