From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/3] cindex: --associate fails when no inboxes are given
Date: Tue, 24 Oct 2023 11:44:27 +0000 [thread overview]
Message-ID: <20231024114429.2998844-2-e@80x24.org> (raw)
In-Reply-To: <20231024114429.2998844-1-e@80x24.org>
This functionality still needs to be fleshed out, but we
definitely can't associate coderepos to inboxes if we don't have
any inboxes as candidates.
---
lib/PublicInbox/CodeSearchIdx.pm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/CodeSearchIdx.pm b/lib/PublicInbox/CodeSearchIdx.pm
index 36d00aea..2d1d8b22 100644
--- a/lib/PublicInbox/CodeSearchIdx.pm
+++ b/lib/PublicInbox/CodeSearchIdx.pm
@@ -930,9 +930,8 @@ sub init_associate_postfork ($) {
require_progs('associate', join => \@JOIN);
$QRY_STR = $self->{-opt}->{'associate-date-range'} // '1.year.ago..';
substr($QRY_STR, 0, 0) = 'dt:';
- scalar(@{$self->{git_dirs} // []}) or die <<EOM;
-E: no coderepos to associate
-EOM
+ @{$self->{git_dirs} // []} or die "E: no coderepos to associate\n";
+ @IBX or die "E: no inboxes to associate\n";
my $approx_git = PublicInbox::Git->new($self->{git_dirs}->[0]); # ugh
$self->query_approxidate($approx_git, $QRY_STR); # in-place
$TODO{associate} = PublicInbox::OnDestroy->new($$, \&associate, $self);
next prev parent reply other threads:[~2023-10-24 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 11:44 [PATCH 0/3] cindex: handle usage errors gracefully Eric Wong
2023-10-24 11:44 ` Eric Wong [this message]
2023-10-24 11:44 ` [PATCH 2/3] t/cindex: use autodie Eric Wong
2023-10-24 11:44 ` [PATCH 3/3] cindex: basic inboxes are non-fatal for --associate Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024114429.2998844-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).