From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] t/nntp.t: attempt to track source of undefined vars
Date: Tue, 10 Oct 2023 09:03:09 +0000 [thread overview]
Message-ID: <20231010090309.327053-1-e@80x24.org> (raw)
Occasionally, t/nntp.t spews undefined variable warnings under
`make check-run'. While the test doesn't fail, it's annoying
to see them and it could be a source of deeper problems.
---
t/nntp.t | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/t/nntp.t b/t/nntp.t
index 0d3384d7..42a4ea97 100644
--- a/t/nntp.t
+++ b/t/nntp.t
@@ -3,14 +3,17 @@
use v5.12;
use PublicInbox::TestCommon;
use PublicInbox::Eml;
-require_mods(qw(DBD::SQLite Data::Dumper));
+require_mods(qw(DBD::SQLite));
use_ok 'PublicInbox::NNTP';
use PublicInbox::Config;
use POSIX qw(strftime);
+use Data::Dumper;
{
my $quote_str = sub {
- my (undef, $s) = split(/ = /, Data::Dumper::Dumper($_[0]), 2);
+ my ($orig) = @_;
+ my (undef, $s) = split(/ = /, Dumper($orig), 2);
+ $s // diag explain(['$s undefined, $orig = ', $orig]);
$s =~ s/;\n//;
$s;
};
reply other threads:[~2023-10-10 9:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010090309.327053-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).