user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/5] kqnotify: drop EV_CLEAR (edge triggering)
Date: Fri,  6 Oct 2023 09:46:00 +0000	[thread overview]
Message-ID: <20231006094604.95809-2-e@80x24.org> (raw)
In-Reply-To: <20231006094604.95809-1-e@80x24.org>

I'm not entirely certain how it works with the way we use
kevent.  I do know IO::KQueue has hard-coded kevent retrievals
to 1000 events so it's conceivable we'd end up missing wakeups
as we don't loop or requeue in callers.  So just rely on the
*BSD kernel to provided requeue behavior for us by using
level-triggering.

In any case, this seems to workaround t/dir_idle.t failures
on Dragonfly due to a tmpfs bug in all versions up to v6.4.
---
 lib/PublicInbox/KQNotify.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/KQNotify.pm b/lib/PublicInbox/KQNotify.pm
index 2efa887d..1689f4cc 100644
--- a/lib/PublicInbox/KQNotify.pm
+++ b/lib/PublicInbox/KQNotify.pm
@@ -26,7 +26,7 @@ sub watch {
 	my $ident = fileno($w->[2]) // die "BUG: bad fileno $w->[2]: $!";
 	$self->{dskq}->{kq}->EV_SET($ident, # ident (fd)
 		EVFILT_VNODE, # filter
-		EV_ADD | EV_CLEAR, # flags
+		EV_ADD, # flags
 		$mask, # fflags
 		0, $dir_delete); # data, udata
 	$self->{watch}->{$ident} = $w;

  reply	other threads:[~2023-10-06  9:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-06  9:45 [PATCH 0/5] Dragonfly BSD support Eric Wong
2023-10-06  9:46 ` Eric Wong [this message]
2023-10-06  9:46 ` [PATCH 2/5] xap_helper.h: strdup keys for DragonFlyBSD hdestroy(3) Eric Wong
2023-10-06  9:46 ` [PATCH 3/5] devel/sysdefs-list: show more info regardless of OS Eric Wong
2023-10-06  9:46 ` [PATCH 4/5] t/dir_idle: dump event list on failure Eric Wong
2023-10-06  9:46 ` [PATCH 5/5] finalize DragonFlyBSD support Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006094604.95809-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).