From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 863101F454
	for <meta@public-inbox.org>; Fri,  6 Oct 2023 09:38:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1696585135;
	bh=G30EPh8a5duxXV8PvZNcEFGb1e9YnOScxO8z3IcLqAw=;
	h=Date:From:To:Subject:References:In-Reply-To:From;
	b=Cp1wWDwCRZ+iXvQOAUI1U7PzUb++/O2+HQB9bJiDNe0Rpg1BgHqvcqnohNVP0C9SC
	 krZ3oStYKXNhuLoSUwXRNVLzUxR8rhtcEeR3g6/LgZ65ooN+NQHtbLMUThMdPvS+o4
	 T7gOmOl75dUuxWlz71U3SO4vmklCcwpP9VjE7t24=
Date: Fri, 6 Oct 2023 09:38:02 +0000
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH] ipc: lower-level send_cmd/recv_cmd handle EINTR directly
Message-ID: <20231006093802.M634465@dcvr>
References: <20231006013713.3762219-1-e@80x24.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231006013713.3762219-1-e@80x24.org>
List-Id: <meta.public-inbox.org>

Eric Wong <e@80x24.org> wrote:
> --- a/t/xap_helper.t
> +++ b/t/xap_helper.t
> @@ -52,8 +52,8 @@ my $doreq = sub {
>  	my $buf = join("\0", @arg, '');
>  	my @fds = fileno($y);
>  	push @fds, fileno($err) if $err;
> -	my $n = PublicInbox::IPC::send_cmd($s, \@fds, $buf, 0);
> -	$n // xbail "send: $!";
> +	my $n = $PublicInbox::IPC::send_cmd->($s, \@fds, $buf, 0) //
> +		xbail "send: $!";

Erm, needs this to quiet a warning:

diff --git a/t/xap_helper.t b/t/xap_helper.t
index 27742cad..7890392d 100644
--- a/t/xap_helper.t
+++ b/t/xap_helper.t
@@ -7,7 +7,7 @@ require_mods(qw(DBD::SQLite Xapian +SCM_RIGHTS)); # TODO: FIFO support?
 use PublicInbox::Spawn qw(spawn);
 use Socket qw(AF_UNIX SOCK_SEQPACKET SOCK_STREAM);
 require PublicInbox::AutoReap;
-require PublicInbox::IPC;
+use PublicInbox::IPC;
 require PublicInbox::XapClient;
 use autodie;
 my ($tmp, $for_destroy) = tmpdir();

Will squash.