From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 84F561F57A for ; Wed, 4 Oct 2023 03:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1696391376; bh=JHqx4NbZN/QswszfTTNmbEux5s5DlveI7ffunJPdu0s=; h=From:To:Subject:Date:In-Reply-To:References:From; b=cIbOmex6VQluV7x97t7seKcaVXQnc+QK8mPkBaeYW86Kx8u7X1fdkCSWxMR2xYS+M lrgfpeJIJemPFCoI4ydr0xujwZUGBLpJXuNP9XPT0WGY4rCcuo7Sb9TeYfg7KhrDbj hdrDXhVNqPb/ChE/+4yer+AUViHMG6HSQTIpn8nk= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 19/21] spawn: drop checks for directory writability Date: Wed, 4 Oct 2023 03:49:31 +0000 Message-ID: <20231004034933.3343930-20-e@80x24.org> In-Reply-To: <20231004034933.3343930-1-e@80x24.org> References: <20231004034933.3343930-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: It's a TOUTTOC bug to do stat or access checks, anyways, so just use the file and let autodie::sysopen PublicInbox::Lock take care of the rest. --- lib/PublicInbox/Spawn.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm index 0dffe064..bb2abe28 100644 --- a/lib/PublicInbox/Spawn.pm +++ b/lib/PublicInbox/Spawn.pm @@ -282,8 +282,6 @@ ALL_LIBC $ENV{XDG_CACHE_HOME} // ( ($ENV{HOME} // '/nonexistent').'/.cache' ) ).'/public-inbox/inline-c'; - warn "$inline_dir exists, not writable\n" if -e $inline_dir && !-w _; - $all_libc = undef unless -d _ && -w _; if (defined $all_libc) { local $ENV{PERL_INLINE_DIRECTORY} = $inline_dir; use autodie;