From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 6/8] net_reader: process title reflects NNTP article
Date: Tue, 3 Oct 2023 06:43:50 +0000 [thread overview]
Message-ID: <20231003064352.2902298-7-e@80x24.org> (raw)
In-Reply-To: <20231003064352.2902298-1-e@80x24.org>
This matches the IMAP behavior with UIDs. While we're in the
area, cut down on LoC a bit and reduce the scope of the $art
variable.
---
lib/PublicInbox/NetReader.pm | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm
index 2d6cb0d6..76fd3892 100644
--- a/lib/PublicInbox/NetReader.pm
+++ b/lib/PublicInbox/NetReader.pm
@@ -788,14 +788,12 @@ sub _nntp_fetch_all ($$$) {
$beg = $num_a if defined($num_a) && $num_a > $beg && $num_a <= $end;
$end = $num_b if defined($num_b) && $num_b >= $beg && $num_b < $end;
$end = $beg if defined($num_a) && !defined($num_b);
- my ($err, $art, $last_art, $kw); # kw stays undef, no keywords in NNTP
- unless ($self->{quiet}) {
- warn "# $uri fetching ARTICLE $beg..$end\n";
- }
+ my ($err, $last_art, $kw); # kw stays undef, no keywords in NNTP
+ warn "# $uri fetching ARTICLE $beg..$end\n" if !$self->{quiet};
my $n = $self->{max_batch};
- for ($beg..$end) {
+ for my $art ($beg..$end) {
last if $self->{quit};
- $art = $_;
+ local $0 = "#$art $group $sec";
if (--$n < 0) {
run_commit_cb($self);
$itrk->update_last(0, $last_art) if $itrk;
next prev parent reply other threads:[~2023-10-03 6:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 6:43 [PATCH 0/8] IMAP/NNTP client improvements Eric Wong
2023-10-03 6:43 ` [PATCH 1/8] net_reader: bail out on NNTP SOCKS connection failure Eric Wong
2023-10-03 6:43 ` [PATCH 2/8] net_reader: avoid IO::Socket::SSL 2.079..2.081 warning Eric Wong
2023-10-03 6:43 ` [PATCH 3/8] config: fix key-only truthy values with urlmatch Eric Wong
2023-10-03 6:43 ` [PATCH 4/8] net_reader: support imap.sslVerify + nntp.sslVerify Eric Wong
2023-10-03 6:43 ` [PATCH 5/8] lei: workers exit after they tell lei-daemon Eric Wong
2023-10-03 6:43 ` Eric Wong [this message]
2023-10-03 6:43 ` [PATCH 7/8] xt/lei-onion-convert: test TLS + SOCKS Eric Wong
2023-10-03 6:43 ` [PATCH 8/8] net_reader: note glob support in .onion hint Eric Wong
2023-10-03 7:11 ` "SSL" in option names is weird in 2023 Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003064352.2902298-7-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).