From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/6] lei_self_socket: drop unused deps and code
Date: Sun, 24 Sep 2023 20:19:19 +0000 [thread overview]
Message-ID: <20230924201922.4031002-4-e@80x24.org> (raw)
In-Reply-To: <20230924201922.4031002-1-e@80x24.org>
We don't need to repeat the assignment done in DS::new,
nor do we need to disable the `once' warnings after
commit cfd20b04dfe4 (ipc: retry sendmsg + recvmsg calls on EINTR)
removed the need for that pragma.
---
lib/PublicInbox/LeiSelfSocket.pm | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/LeiSelfSocket.pm b/lib/PublicInbox/LeiSelfSocket.pm
index 690cda3f..84367266 100644
--- a/lib/PublicInbox/LeiSelfSocket.pm
+++ b/lib/PublicInbox/LeiSelfSocket.pm
@@ -5,20 +5,17 @@
# This receives what script/lei receives, but isn't connected
# to an interactive terminal so I'm not sure what to do with it...
package PublicInbox::LeiSelfSocket;
-use strict;
-use v5.10.1;
+use v5.12;
use parent qw(PublicInbox::DS);
use Data::Dumper;
$Data::Dumper::Useqq = 1; # should've been the Perl default :P
use PublicInbox::Syscall qw(EPOLLIN);
-use PublicInbox::Spawn;
use PublicInbox::IPC;
sub new {
my ($cls, $r) = @_;
- my $self = bless { sock => $r }, $cls;
+ my $self = bless {}, $cls;
$r->blocking(0);
- no warnings 'once';
$self->SUPER::new($r, EPOLLIN);
}
next prev parent reply other threads:[~2023-09-24 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 20:19 [PATCH 0/6] various test and syscall-related fixes Eric Wong
2023-09-24 20:19 ` [PATCH 1/6] test_common: fixes for TEST_RUN_MODE=0 Eric Wong
2023-09-24 20:19 ` [PATCH 2/6] t/cmd_ipc: assume SOCK_SEQPACKET Eric Wong
2023-09-24 20:19 ` Eric Wong [this message]
2023-09-24 20:19 ` [PATCH 4/6] ipc: recv_cmd4 clobbers destination buffer on errors Eric Wong
2023-09-24 20:19 ` [PATCH 5/6] syscall: have `vec' operate on bytes directly Eric Wong
2023-09-24 20:19 ` [PATCH 6/6] syscall: fix valgrind error in pure Perl send_cmd4 Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230924201922.4031002-4-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).