From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2B3111F55F for ; Thu, 14 Sep 2023 12:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1694693576; bh=uaYB0dIYX/ehuTc6lZp3L/lv6qN91weHptDhEnjIDr0=; h=From:To:Subject:Date:From; b=WDr8NNOCT6pX2SZGOnCCIrX1Ddb8YzvfLOjSZZQp64bJElgACTqM+0RtS3oTsGFu9 Zzjx/ddjVYytetfbcZAuSFyV85P6+2vUWKpNLK1ujUDciDTOt1I9IWHj7+TZCeKRWd pSc+pYnHnVNCHTj+voWH5Q63l5808ldEiq6GDdcQ= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] t/lei-mirror: do not bail out on `make help' failure Date: Thu, 14 Sep 2023 12:12:55 +0000 Message-ID: <20230914121256.1897288-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: I'm not sure why, but this test occasionally fails on OpenBSD and I can't reproduce it on a repeatable basis. In any case, there's no reason we can't continue the rest of the test if `make help' fails. --- t/lei-mirror.t | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/lei-mirror.t b/t/lei-mirror.t index 2400578a..9b5d73ec 100644 --- a/t/lei-mirror.t +++ b/t/lei-mirror.t @@ -27,7 +27,8 @@ test_lei({ tmpdir => $tmpdir }, sub { "mirror of $http/t1/\n", 'description set'); ok(-f "$t1/Makefile", 'convenience Makefile added (v1)'); my $make = which('make'); - xsys_e([$make, 'help'], undef, { -C => $t1, 1 => \(my $help) }); + is(xsys([$make, 'help'], undef, { -C => $t1, 1 => \(my $help) }), 0, + 'make help'); ok(-f "$t1/inbox.config.example", 'inbox.config.example downloaded'); isnt($help, '', 'make help worked'); is((stat(_))[9], $created{v1},