user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 6/8] xap_helper: note __cleanup__ works with C++ exceptions
Date: Sat,  9 Sep 2023 12:01:40 +0000	[thread overview]
Message-ID: <20230909120142.1041752-7-e@80x24.org> (raw)
In-Reply-To: <20230909120142.1041752-1-e@80x24.org>

In case somebody reviewing this code gets curious.
---
 lib/PublicInbox/xap_helper.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/PublicInbox/xap_helper.h b/lib/PublicInbox/xap_helper.h
index 70760367..3f45e1c7 100644
--- a/lib/PublicInbox/xap_helper.h
+++ b/lib/PublicInbox/xap_helper.h
@@ -322,6 +322,9 @@ struct dump_roots_tmp {
 	int root2id_fd;
 };
 
+// n.b. __cleanup__ works fine with C++ exceptions, but not longjmp
+// Only clang and g++ are supported, as AFAIK there's no other
+// relevant Free(-as-in-speech) C++ compilers.
 #define CLEANUP_FBUF __attribute__((__cleanup__(fbuf_ensure)))
 static void fbuf_ensure(void *ptr)
 {

  parent reply	other threads:[~2023-09-09 12:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-09 12:01 [PATCH 0/8] NetBSD-related updates Eric Wong
2023-09-09 12:01 ` [PATCH 1/8] Makefile.PL: check `getconf NPROCESSORS_ONLN', too Eric Wong
2023-09-09 12:01 ` [PATCH 2/8] ipc: define _SC_NPROCESSORS_ONLN for NetBSD Eric Wong
2023-09-09 12:01 ` [PATCH 3/8] ci/run.sh: parameterize BUILD_JOBS TEST_JOBS and TEST_TARGET Eric Wong
2023-09-09 12:01 ` [PATCH 4/8] ci/profiles: rewrite in Perl Eric Wong
2023-09-09 21:14   ` [SQUASH] manifest update Eric Wong
2023-09-09 12:01 ` [PATCH 5/8] update CI helper scripts for NetBSD and `pkgin' Eric Wong
2023-09-09 12:01 ` Eric Wong [this message]
2023-09-16 13:10   ` [PATCH] xap_helper: test cleanup + throw support in C++ Eric Wong
2023-09-09 12:01 ` [PATCH 7/8] xap_helper: use _OPENBSD_SOURCE on NetBSD for reallocarray Eric Wong
2023-09-09 12:01 ` [PATCH 8/8] xap_helper: clamp workers to USHRT_MAX Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230909120142.1041752-7-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).