From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 106F01F452 for ; Fri, 7 Apr 2023 12:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1680871254; bh=7vIrfBq2qQt3Y/sZEipj3UzvA7BBvYBoy9gTiRFMFxU=; h=From:To:Subject:Date:From; b=smcNKHkfADplczrZqZdqmNv14fs1O/RowS2QnYTLfguLayT9VoJXlBPCyJuVl9NXu ahRJvwFa2bTSAA1sOperSNNlIm6N/IRGQNOkptZ/rj2TqkTxCAGgLBA7EO/ltRP4QO avXaMLm9VuOK82A09wdyNGdiiMasAOsM/Ql5NxyE= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 0/6] cindex fixes, and some spring cleaning Date: Fri, 7 Apr 2023 12:40:47 +0000 Message-Id: <20230407124053.2233988-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: cindex now preserves indexlevel like older mail-based indices We'll reuse umask code across inboxes, extindex, and now cindex for code. This also lets us simplify some of our old code by eliminating some useless functions. The vstring stuff should make the code more readable to new contributors. Eric Wong (6): cindex: improve progress display cindex: preserve indexlevel across invocations umask: hoist out of InboxWritable umask: rely on the OnDestroy-based call where applicable searchidx: use vstring to improve readability switch git version comparisons to vstrings, too MANIFEST | 1 + lib/PublicInbox/CodeSearchIdx.pm | 49 ++++++++++++---------- lib/PublicInbox/ExtSearchIdx.pm | 17 +++----- lib/PublicInbox/Git.pm | 11 +++-- lib/PublicInbox/InboxWritable.pm | 70 +------------------------------- lib/PublicInbox/LeiMirror.pm | 2 +- lib/PublicInbox/SearchIdx.pm | 37 ++++++++--------- lib/PublicInbox/TestCommon.pm | 16 +++----- lib/PublicInbox/Umask.pm | 70 ++++++++++++++++++++++++++++++++ lib/PublicInbox/V2Writable.pm | 23 ++++------- lib/PublicInbox/Xapcmd.pm | 35 ++++++++-------- script/public-inbox-convert | 9 ++-- t/cindex.t | 45 ++++++++++++++++++++ t/search.t | 7 ++-- 14 files changed, 212 insertions(+), 180 deletions(-) create mode 100644 lib/PublicInbox/Umask.pm