From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 67A951F428 for ; Wed, 15 Mar 2023 21:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1678916876; bh=s0CPbe7m6QcapvB9IjD2jOb3SAJud6Frg/PmNo1Ocmo=; h=From:To:Subject:Date:From; b=M1bBvJrNGky++NTgO4TA+89xNPPKy2p1wSHeB6h1mHgPWymSCFpfYSSeWSogFy8Uz pF3cA5HlACjGgBrs+g0PBoyVafCOEK3po1tYJrLJKO1ye9RQ/+pcly0dkyWXI1nsZk JFw/Y6IxcRwhSevR/Ago8NJJou1m7HpnpaHCDIkA= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] ds: reap_pids: remove redundant signal blocking Date: Wed, 15 Mar 2023 21:47:56 +0000 Message-Id: <20230315214756.3715429-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Blocking signals when reaping was done when the lei pager was spawned by the daemon in b90e8d6e02. Shortly afterwards in 7b79c918a5, the client script took over spawning of the pager and made b90e8d6e02 redundant. cf. b90e8d6e02 (ds: block signals when reaping, 2021-01-10) 7b79c918a5 (lei: run pager in client script, 2021-01-10) --- lib/PublicInbox/DS.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm index a08e01f5..b6eaf2d7 100644 --- a/lib/PublicInbox/DS.pm +++ b/lib/PublicInbox/DS.pm @@ -214,7 +214,6 @@ sub await_cb ($;@) { # that to remain the case. sub reap_pids { $reap_armed = undef; - my $oldset = block_signals(); while (1) { my $pid = waitpid(-1, WNOHANG) // last; last if $pid <= 0; @@ -224,7 +223,6 @@ sub reap_pids { warn "W: reaped unknown PID=$pid: \$?=$?\n"; } } - sig_setmask($oldset); } # reentrant SIGCHLD handler (since reap_pids is not reentrant)