From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 5FAB21F47D for ; Mon, 13 Mar 2023 12:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1678708825; bh=e2d2kuGMsZwGCPNvMbtI1N1P6cxDiWd7n7UiPjz4Cz0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=28LweOvKsLe7aop6als+HccOdwXbOP7vW42xSAGPBAfDJX2J2TjS/kyISDUoImisu ovNhRmP5m7cwutZ+7FAf3YLme9kg1bFDuERM21fkjupm/F4UwMqI7F9YwpdcyJAvXZ kIKAAKRYBI70KpM+Aj0g27AAnokyTBrP0pvM98Cc= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/5] lei_mirror: do not fetch to read-only directories Date: Mon, 13 Mar 2023 12:00:22 +0000 Message-Id: <20230313120024.1911925-4-e@80x24.org> In-Reply-To: <20230313120024.1911925-1-e@80x24.org> References: <20230313120024.1911925-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: As with public-inbox-fetch, we shouldn't waste time fetching into read-only directories, since --epoch= will make unwanted epoch directories read-only placeholders. --- lib/PublicInbox/LeiMirror.pm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm index 967a6422..3ec8170f 100644 --- a/lib/PublicInbox/LeiMirror.pm +++ b/lib/PublicInbox/LeiMirror.pm @@ -593,8 +593,15 @@ sub clone_v1 { die "$uri is a v1 inbox, --epoch is not supported\n"; $self->{-torsocks} //= $curl->torsocks($lei, $uri) or return; my $dst = $self->{cur_dst} // $self->{dst}; - my $fini = PublicInbox::OnDestroy->new($$, \&v1_done, $self); my $resume = -d $dst; + if ($resume) { # respect read-only cloned w/ --epoch= + my @st = stat(_); # for root + if (!-w _ || !($st[2] & 0222)) { + warn "# skipping $dst, not writable\n"; + return; + } + } + my $fini = PublicInbox::OnDestroy->new($$, \&v1_done, $self); if (my $fgrp = forkgroup_prep($self, $uri)) { $fgrp->{-fini} = $fini; if ($resume) {