user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/5] lei_mirror: describe why the {ibx} field is used
Date: Mon, 13 Mar 2023 12:00:20 +0000	[thread overview]
Message-ID: <20230313120024.1911925-2-e@80x24.org> (raw)
In-Reply-To: <20230313120024.1911925-1-e@80x24.org>

I forgot why that hunk of code was needed :x, so maybe others
will find the comment helpful, too.
---
 lib/PublicInbox/LeiMirror.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm
index c148ebfd..d878f1e4 100644
--- a/lib/PublicInbox/LeiMirror.pm
+++ b/lib/PublicInbox/LeiMirror.pm
@@ -194,7 +194,7 @@ sub _write_inbox_config {
 		die "open($f): $!";
 	}
 	my $cfg = PublicInbox::Config->git_config_dump($f, $self->{lei}->{2});
-	my $ibx = $self->{ibx} = {};
+	my $ibx = $self->{ibx} = {}; # for indexing
 	for my $sec (grep(/\Apublicinbox\./, @{$cfg->{-section_order}})) {
 		for (qw(address newsgroup nntpmirror)) {
 			$ibx->{$_} = $cfg->{"$sec.$_"};

  reply	other threads:[~2023-03-13 12:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 12:00 [PATCH 0/5] clone improvements Eric Wong
2023-03-13 12:00 ` Eric Wong [this message]
2023-03-13 12:00 ` [PATCH 2/5] lei_mirror: do not re-fetch inbox.config.example Eric Wong
2023-03-13 12:00 ` [PATCH 3/5] lei_mirror: do not fetch to read-only directories Eric Wong
2023-03-13 12:00 ` [PATCH 4/5] lei_mirror: handle UTF-8 from manifest.js.gz properly Eric Wong
2023-03-13 12:00 ` [PATCH 5/5] doc: clone: document --remote-manifest= option Eric Wong
2023-03-13 23:34   ` Kyle Meyer
2023-03-14 20:50     ` [PATCH] doc: clone: fix typo in --remote-manifest= description Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230313120024.1911925-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).