From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 8AA1C1F5A0
	for <meta@public-inbox.org>; Fri,  3 Feb 2023 03:46:03 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1675395963;
	bh=617CEDTSpve9ZOwhIWvQCUTz4KjfFBhkKcsjEhiU27M=;
	h=From:To:Subject:Date:From;
	b=D1HdbousD6H9Ta1rjfgEAZyH3OeKefrzDZpBfTqfqFnEZBkXF1T2FeMqvRTr1aCk4
	 9zMaFvEcaADPBgFw4ZcpLo1rRVmgJa8G9bOXOSYJl2EuSmAQc2CromDELJ6QCATbeT
	 3O6bnDKcBmSsfGP9xxI70uMkNKpxSEGYx2jRvEns=
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] lei_mirror: use --no-write-fetch-head on git 2.29+
Date: Fri,  3 Feb 2023 03:46:03 +0000
Message-Id: <20230203034603.3958259-1-e@80x24.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
List-Id: <meta.public-inbox.org>

This avoids unnecessary writes to the FETCH_HEAD file, which is
worthless in multi-remote mirrors.  Actually, I haven't found
FETCH_HEAD useful anywhere since the `/remotes/' namespace
became popular...
---
 lib/PublicInbox/Git.pm       | 5 +++++
 lib/PublicInbox/LeiMirror.pm | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index fd7a0382..2729b38f 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -52,6 +52,11 @@ my %ESC_GIT = map { $GIT_ESC{$_} => $_ } keys %GIT_ESC;
 my $EXE_ST = ''; # pack('dd', st_ctime, st_size);
 my ($GIT_EXE, $GIT_VER);
 
+sub version {
+	check_git_exe();
+	$GIT_VER;
+}
+
 sub check_git_exe () {
 	$GIT_EXE = which('git') // die "git not found in $ENV{PATH}";
 	my @st = stat($GIT_EXE) or die "stat: $!";
diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm
index ec2b56df..4c564c84 100644
--- a/lib/PublicInbox/LeiMirror.pm
+++ b/lib/PublicInbox/LeiMirror.pm
@@ -16,6 +16,7 @@ use Carp qw(croak);
 use URI;
 use PublicInbox::Config;
 use PublicInbox::Inbox;
+use PublicInbox::Git;
 use PublicInbox::LeiCurl;
 use PublicInbox::OnDestroy;
 use PublicInbox::SHA qw(sha256_hex sha1_hex);
@@ -275,6 +276,8 @@ sub fetch_args ($$) {
 			($lei->{opt}->{jobs} // 1) > 1;
 	push @cmd, '-v' if $lei->{opt}->{verbose};
 	push(@cmd, '-p') if $lei->{opt}->{prune};
+	PublicInbox::Git::version() >= ((2 << 24) | (29 << 16)) and
+		push(@cmd, '--no-write-fetch-head');
 	@cmd;
 }